]> git.koha-community.org Git - koha.git/commit
Bug 20076: (RM follow-up) Fix system preference boolean logic
authorFridolin Somers <fridolin.somers@biblibre.com>
Fri, 14 Jan 2022 01:33:09 +0000 (15:33 -1000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 14 Jan 2022 02:37:33 +0000 (16:37 -1000)
commit8a8e1056957deb683f128bc4b65ab36538d167ea
tree2a10c0bcfbdada7b595374648ab698d2bd6d9547
parentcbd9b75e6bbd01d3842c98d49cbfe725f1cdbaef
Bug 20076: (RM follow-up) Fix system preference boolean logic

A Yes/No system preference must use 1 for Yes and 0 for No.
So "Send" for 1/Yes and "Don't send" for 0/No.
We add too much problems with double-negation boolean system preferences (such as dontmerge).

Previous patch changed default value to 1 in atomicupdate, do the same
in installer/data/mysql/mandatory/sysprefs.sql

Also to be consistant, sets options = NULL instead of '' in atomicupdate

Also removed useless added empty line in /misc/cronjobs/overdue_notices.pl

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
installer/data/mysql/atomicupdate/add-system-preference-EmailOverduesNoEmail.perl [deleted file]
installer/data/mysql/atomicupdate/bug_20076-add_system_preference_EmailOverduesNoEmail.pl [new file with mode: 0755]
installer/data/mysql/mandatory/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
misc/cronjobs/overdue_notices.pl