]> git.koha-community.org Git - koha.git/commit
Bug 28012: Use definedness test instead of bool when checking whether to null fields
authorJoonas Kylmälä <joonas.kylmala@iki.fi>
Sat, 3 Sep 2022 10:37:31 +0000 (13:37 +0300)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 12 Jan 2024 22:08:53 +0000 (22:08 +0000)
commit8a9f2a05e0a5199386859ee8dbc51748a135f13a
tree40be33b6c3ff465fb18a28d886dd50e30284508b
parent97939c87b7baacf450d3cf6331d07e19d8f6fc29
Bug 28012: Use definedness test instead of bool when checking whether to null fields

Saving a new numbering pattern didn't work without having to fill all
the fields, even those that are not mandatory.

To test:
 1) Go to /cgi-bin/koha/serials/subscription-numberpatterns.pl
    and try creating a new pattern, notice that only Name and
    Description are mandatory after applying this patch
 2) Make sure editing existing numbering patterns still works

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 97aab6a98e05ed989e7cc719450d274c80e34bb9)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit d4a81e4c2a40ed91513eb2877c79645e9192d32e)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
serials/subscription-numberpatterns.pl