]> git.koha-community.org Git - koha.git/commit
Bug 15339: [QA Follow-up] Add a warning too when source is not supplied
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 7 Sep 2017 07:24:28 +0000 (09:24 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 7 Sep 2017 16:35:06 +0000 (13:35 -0300)
commit8cb6ed24ffb6f7bfa74b7ea4062070cc5cd0e6d2
tree8a0773f5579059d29a9aad40709560e64d7dd5d7
parentd60cc56613755a432bb0962b2e808229c8c575c1
Bug 15339: [QA Follow-up] Add a warning too when source is not supplied

When you do not supply a source and add a few wrong parameters, you
would not be warned. Because build simply returns undef.
Adding a carp and a test for that situation too.

Note: In the earlier subtest 'trivial tests' build was called without
source. This now generates a warning. We just catch if there is a warning
and test the actual warning itself later on.

Test plan:
Run t/db_dependent/TestBuilder.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
t/db_dependent/TestBuilder.t
t/lib/TestBuilder.pm