]> git.koha-community.org Git - koha.git/commit
Bug 26231: Remove incorrect use of AddAuthority() when 001 present
authorDavid Cook <dcook@prosentient.com.au>
Tue, 18 Aug 2020 02:20:32 +0000 (12:20 +1000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 28 Sep 2020 08:09:52 +0000 (10:09 +0200)
commit9622561636387ced932cc31e285d13cdba607c47
tree5f7311dc613bfb7517237f7661c070d73a33e17d
parente708566e729239ed7857c357ee53419c44742ddd
Bug 26231: Remove incorrect use of AddAuthority() when 001 present

This patch removes the use of AddAuthority with a non-empty
authid argument, since that triggers an update rather than an insert.

In practice, the update also fails, but the error isn't raised,
as the database connection doesn't have RaiseError set.

Test plan:
1) Do not apply patch
2) Try to bulkmarcimport an authority file with a 001
3) Observe that the script reports success but no authority is added
4) Apply the path
5) Try to bulkmarcimport an authority file with a 001
6) Observe that the script reports success and the authority is added

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
misc/migration_tools/bulkmarcimport.pl