]> git.koha-community.org Git - koha.git/commit
Bug 9209 - Mocked Koha::Calendar tests
authorTomas Cohen Arazi <tomascohen@gmail.com>
Tue, 4 Dec 2012 18:14:59 +0000 (15:14 -0300)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Sat, 29 Dec 2012 01:15:35 +0000 (20:15 -0500)
commit99410d7ce47a1fd4af1bcd534d0135b62b52c2e5
tree60974bffcef3b41ac0131e9ee2c9ed3b187c77c5
parentac723d8e9bb77854101098a76677fae01eb1746e
Bug 9209 - Mocked Koha::Calendar tests

Using specific method for populating the internal data structures from Koha::Calendar
has yielded to the non-detection of several bugs. There are also several tests that where
db_dependent which is not always desirable.

I propose the use of DBD::Mock (::Session) for using the actual code used by Koha in production
for testing, mocking the DB queries itselves.

I also took the time to repeat several tests in different syspref configurations (they applied
only to daysMode=Calendar, and now cover all confs).

Notes:
- I used DBD:Mock 1.45 as previous version (1.43, from 12.04) was broken
- Some tests revealed a bug on days_between as I see it... reporting as Bug #9211

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Koha/Calendar.pm
t/Calendar.t