]> git.koha-community.org Git - koha.git/commit
Bug 18759: Try to fix random failure from Circulation.t
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 8 Jun 2017 14:54:18 +0000 (11:54 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 8 Jun 2017 15:13:56 +0000 (12:13 -0300)
commit9a55f5783c91b92cb8518f423ab23bd9727051ee
tree4313636eaac1de57f7ec2329a46b3bad9b622e55
parentb5b046599b6604c6cfd681d8392c560b3df738d2
Bug 18759: Try to fix random failure from Circulation.t

Circulation.t is failing randomly on our CI
https://jenkins.koha-community.org/job/Koha_Master_D8/192/console

    #   Failed test at t/db_dependent/Circulation.t line 1147.
    #          got: '1'
    #     expected: '0'

    #   Failed test at t/db_dependent/Circulation.t line 1152.
    #          got: '1'
    #     expected: '0'

    #   Failed test at t/db_dependent/Circulation.t line 1156.
    #          got: '1'
    #     expected: '0'

    #   Failed test at t/db_dependent/Circulation.t line 1170.
    #          got: '1'
    #     expected: '0'

    #   Failed test at t/db_dependent/Circulation.t line 1184.
    #          got: '1'
    #     expected: '0'
    # Looks like you failed 5 tests of 23.

Sometimes one of the alert or impossible flags is set.
This patch guesses that it's because of the 'restricted' value of the item that is evaluated to 1.
If it is not fixed by this patch, we will have more info next time (at least know
if alert or impossible is set).

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
The fix is trivial. Using random data will lead to this situations. The good thing is that
it lets us spot places in which tests need more fine-grained data.
t/db_dependent/Circulation.t