]> git.koha-community.org Git - koha.git/commit
Bug 19832: Don't fill holds in SIP/Transaction/Checkout.pm
authorNick Clemens <nick@bywatersolutions.com>
Wed, 16 Jan 2019 13:19:45 +0000 (13:19 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 15 Feb 2019 18:42:44 +0000 (18:42 +0000)
commitc3b41cb12465249cc87ed8866855e06e61842872
tree866fdc5404ca547fc4d346389718c7d2d2b5f6f9
parent50fd86d42fa76b3840c61ea004d026d4810bc4dc
Bug 19832: Don't fill holds in SIP/Transaction/Checkout.pm

AddIssue already checks for holds in the item being issued and deals with them

The sip code, additionally, does not consider that multiple holds per bib
is allowed

To test:
 0 - Apply only first patch (unit tests)
 1 - Place two holds for a patron on a bib
 2 - Checkout that item via sip_cli_emulator
 3 - Note all holds are cancelled/filled
 4 - prove -v t/db_dependent/SIP/Transaction.t
 5 - it fails
 6 - Apply second patch
 7 - prove tests, all green
 8 - Place two holds on a single bib for one patron again
 9 - Checkout the item via sip_cli_emulator
10 - Only one holds is filled

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/SIP/ILS/Transaction/Checkout.pm