]> git.koha-community.org Git - koha.git/commit
Bug 33597: Fix deleting cookie for holdfor(club)
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 24 Apr 2023 10:35:26 +0000 (10:35 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 11 May 2023 12:18:21 +0000 (13:18 +0100)
commitd8567143eea4dde52cce0c856e3c12a6154eda0b
tree42467c002c9daa934246cf39b1898f6f3febd04c
parentd11c9fec33f6ebb072094437240408bd8f300a9f
Bug 33597: Fix deleting cookie for holdfor(club)

Resolve:
Cookie “holdfor” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it.

Did not see warning for holdforclub. But since it is created with Lax, we should remove it with Lax.

Test plan:
Similar to previous patch. Check console on logout page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7e5e311cb0c88b9223ce98d685668962edc7baee)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/js/pages/results.js
koha-tmpl/intranet-tmpl/prog/js/staff-global.js