]> git.koha-community.org Git - koha.git/commit
Bug 12899: Row grouping in checkouts table is alphabetical and depends on translation
authorOwen Leonard <oleonard@myacpl.org>
Wed, 10 Sep 2014 12:56:24 +0000 (08:56 -0400)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Tue, 16 Sep 2014 18:20:51 +0000 (15:20 -0300)
commitd8ed9130593d1d83be1674de076f7f2367039d9c
treef54947ba8a8f4bdc2ddda4ee589b7e3d133bf7ce
parent7289214e30083ae6addb9137b0480ea5b68b8d71
Bug 12899: Row grouping in checkouts table is alphabetical and depends on translation

The sort order of the "today's checkouts" and "previous checkouts" row
groupings depends on the label, so in English "today's checkouts" comes
first. However, in other languages the reverse alphabetical order is
incorrect resulting in "previous checkouts" coming first.

This patch adds a dummy column with numeric data on which the sorting
can be done. This should make it translation-agnostic.

To test, apply the patch and install or update a translation which will
demostrate the problem (sv-SE for instance).

- Clear your browser cache and switch to the English templates.
- Check out some items to a patron who has checkouts from a previous
  day.
- Confirm that the sorting of the "today's checkouts" and "previous
  checkouts" row groups is correct.
- Switch to the new/updated translation and reload the circulation page
  for that patron. Confirm that the sort remains correct.
- Confirm that the checkouts table looks correct and that other features
  (sorting, checkboxes) still work correctly.

Revision: Corrected the table footer include to correct the colspan
error causing column misalignment.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table-footer.inc
koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt