]> git.koha-community.org Git - koha.git/commit
bug 9505 refactor loops in invoices.pl
authorColin Campbell <colin.campbell@ptfs-europe.com>
Wed, 30 Jan 2013 08:50:23 +0000 (08:50 +0000)
committerGalen Charlton <gmc@esilibrary.com>
Thu, 30 May 2013 14:12:03 +0000 (07:12 -0700)
commite294defc299e97fe5e1ecfdeb648e8f8f080f5f5
tree9886bbf37c484bcb026e641369a1ab40bd688382
parenta90a72c62dcfcbb1989d5ea60a80f51bcee8a23d
bug 9505 refactor loops in invoices.pl

- Remove an unnecessary loop where output just
  recreated input.
- Remove unnecessary temp variables that obscure code purpose.
- Call the variable containing invoices, invoices
  rather than anonymous and ambiguous results
  reflect namechange in template.
- Lists are passed to template as array refs;
  declare them as scalars as that is how we use them.
- No need to introduce the whole namespace of some C4
  modules for 1 routine.

Test plan:

Note that this patch should not change any visible behavior.

[1] Open the invoice search page.
[2] Verify that the list of suppliers in the drop-down
    on the search form is complete.
[3] Verify that the list of libraries in the drop-down
    on the saerch form is complete.
[4] Perform a search.  Verify that the list of invoices
    is correct.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
acqui/invoices.pl
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt