]> git.koha-community.org Git - koha.git/commit
Bug 12876 - Reserve in waiting/transfer status may be cancelled by user
authorRafal Kopaczka <rkk0@poczta.onet.pl>
Fri, 5 Sep 2014 12:50:15 +0000 (14:50 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Tue, 23 Sep 2014 23:46:50 +0000 (20:46 -0300)
commite9eef04b95e7cb0dadda862f07c0d34a31f5eb6a
tree0ff24cddf5950ef0be80ac3fce43dce09bacc1e3
parent6a98db50fc56be0d611170507c2ced445b894970
Bug 12876 - Reserve in waiting/transfer status may be cancelled by user

User may cancel his own reservation at waiting or in transit status
through calling opac-modrequest.pl. Cancel button is disabled in
interface but possibility to cancel should be checked also in
opac-moderequest.pl, before calling CancelReserve().
Similar situation is with opac-modrequest-suspend.pl

This patch provides new soubroutine to chceck if user can cancel given
reserve. It's possible only when he's owner of hold and hold isn't in
transfer or waiting status.

Additionaly there are new test for this function in Reserves.t

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests, QA script and new tests.
Works as described, tested with:
.../cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Reserves.pm
opac/opac-modrequest-suspend.pl
opac/opac-modrequest.pl
t/db_dependent/Reserves.t