]> git.koha-community.org Git - koha.git/commit
Bug 33028: (follow-up) Lower the two digits requirement
authorTomas Cohen Arazi <tomascohen@theke.io>
Wed, 19 Jul 2023 14:51:54 +0000 (11:51 -0300)
committerPedro Amorim <pedro.amorim@ptfs-europe.com>
Thu, 17 Aug 2023 16:02:18 +0000 (16:02 +0000)
commitebd4a6cfa7ae59b8c67c8b34f7913c223c44455d
tree569800f3fdf01d4f1873b145b61c9a0986409aed
parent0b9a2b8b55fcb89cde381ebd2642af914419b4b1
Bug 33028: (follow-up) Lower the two digits requirement

This patch makes the code not require two decimal digits, as the main
intention here is to forbid (locale) formatted strings to reach the DB.

The number of digits we support needs to be discussed on its own bug,
and a centralized check implemented.

This patch fixes tests:

prove t/db_dependent/Circulation.t
t/db_dependent/Circulation.t .. 1/67 Exception 'Koha::Exceptions::CirculationRule::NotDecimal' thrown 'The circulation rule expected a decimal value' with name => fine, value => 0.1
t/db_dependent/Circulation.t .. Dubious, test returned 11 (wstat 2816, 0xb00)
Failed 53/67 subtests

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 45b050871e7ed882b553f211db97204f30634646)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 343221462e71101c13fa39bae5abb87c956e412d)
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Koha/CirculationRules.pm