]> git.koha-community.org Git - koha.git/commit
Bug 21172: Remove warning from addbiblio.pl
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 7 Aug 2018 20:06:41 +0000 (17:06 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Wed, 17 Apr 2019 10:23:23 +0000 (10:23 +0000)
commitf3afec0587f4baeff580e153ea592020d4d36be3
treed7b6ab1136263a9bd7e45850b5fd7d04e610c182
parent4177d2e32942b16e65748852df881541406297bd
Bug 21172: Remove warning from addbiblio.pl

Argument "01e" isn't numeric in numeric ne (!=) at
/home/vagrant/kohaclone/cataloguing/addbiblio.pl line 507.

A tagfield can be 01e and so raise a warning is compared with == or !=

This patch also fixes few inconsistencies:
- tagfield for items.itemnumber must be retrieved with GetMarcFromKohaField
(to support other marcflavours)
- do not use $_
- loop only once on $usedTagsLib

Test plan:
For devs only, read the code and confirm the changes make sense.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
cataloguing/addbiblio.pl