]> git.koha-community.org Git - koha.git/commit
Bug 2969 - Report Name should be mandatory for saved reports
authorOwen Leonard <oleonard@myacpl.org>
Wed, 23 Jan 2013 15:05:22 +0000 (10:05 -0500)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Fri, 24 Oct 2014 12:47:37 +0000 (09:47 -0300)
commitf9965d53c2c0bed10407b27874ae5dadb2c64e6c
treeb139773cdd52303056785a421ddc43b129950734
parentf41a30fe38207d8e11782041e28bdff3b57a5627
Bug 2969 - Report Name should be mandatory for saved reports

This patch re-implements the database changes from the original patch
and adds an update for existing reports. It also reimplements the
client-side validation using the new built-in validation plugin and adds
coverage for SQL reports.

I have also added the "required" attribute to the SQL report textarea
since saving a report with no SQL triggers an error.

To test:

- Create a new guided report. Confirm that you cannot save your guided
  report without a report name.
- Create or edit a saved SQL report. Confirm that you cannot save your
  report without a name or without SQL.
- Confirm that the saved_sql table structure has been updated.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Functional tests pass, database tables look correct to me.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Even with JS disabled, the form can not be submitted without the
report name filled in.
However we are not checking this server side .. if this was the public
interface that would be a fail. I will leave this up to the RM to
decided if client side checks are ok for this. Bearing in mind we
weren't handling any sql errors properly server side before this.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: description of the updatedb entry

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
installer/data/mysql/kohastructure.sql
installer/data/mysql/updatedatabase.pl
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt