do not let MARC::Batch open MARC files

The version of MARC::Batch->new() distributed with version
2.0.0 of MARC::Record, if given a file name, will
open it using the ':utf8' layer.  This results in an
incorrect character conversion when processing records
in the MARC-8 character encoding.

To avoid this, batch jobs that use MARC::Batch now
open the file themselves, then pass the file handle
to MARC::Batch->new().

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

remove some unneeded use statements

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing branch select onChange() function, hopefully fixes Bug 1957, Holiday Calendar broken in Internet Explorer

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

partial fix for bug 1417

The Notes field should now be displayed correctly
when editing an order - the query in GetOrder
was modified to have aqorder's notes column
appear last, which means that it is the one
selected for the data hash (instead of biblio.notes
or biblioitems.notes).

This is an ugly fix - GetOrder needs to be
refactored so that it doesn't depend on
selecting all columns from several different
tables.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug: 1953. cleaning up Acquisition::NewOrder just a little bit.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug: 1953. using placeholders in C4::Acquisition::NewOrder.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1953: using placeholders in C4::Acquisition::GetParcel

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1953: using placeholders in C4::Acquisition::GetParcel

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some reworking of suggestions management interface in preparation for tackling hdl's proposal of wider scope. Includes change to Suggestions.pm to enable passing of borrowernumber to the template.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug fix : 1804 : Now empty authorities and empty search return results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug fixing : 1746 : password was not escaped.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some Bugfixing for Acquisitions : ModOrderReceive would create 2 lines in baskets And titles were displayed twice in parcel.tmpl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug fixing : when closing a basket, supplier was searched by name, not by id.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

don't display the name of the library in singleBranchMode

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing singlebranchmode display issues

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding OPACShelfbrowse to OPAC tab

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing availability limit

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding title indexes for 780

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

don't show library facet if singleBranchMode is ON

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding a couple benchmark scripts

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

obey opaclanguagesdisplay syspref

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1953: use bind variables in C4::Acquisition::GetPendingOrders

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

use bind variables in C4::Acquisition::GetPendingOrders

I improved the tests a bit for this module so that they at least skip
if there's not enough data in the database to test with.
I was unable to test the actual execution path through the change I actually made.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Markup correction.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix to enable OPACUserCSS preference (allows user to add CSS globally in the OPAC via an embedded style block)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More changes to properly implement opacuserlogin preference.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changes to properly implement opacuserlogin preference.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changes to allow highlighting of current tab on user pages.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Updates to tweak the way suggestions and suggestions links display when various suggestions-related prefs are on or off.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Commenting out unused call to get_batches.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Modifications to viewlog.pl to keep it in the context from which it was called.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Correcting warn concerning kohaversion.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Updating patronimages syspref to reflect current sysprefs.sql

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

use bind variables in GetBorrowersWhoHaveNotBorrowedSince query

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more old_issues SQL cleanup

* no need to test for 'returndate is null' in queries
  on old_issues
* added more stylistic corrections

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Revert "Updatedatabase UPDATE For more_subfields_xml to be added to deleteditems at the same time as it is to items."

This reverts commit eaac37aa6ea8c4f2b79adaa4186bc08a9ac9efd4.

Rev 052 in updatedatabase.pl already adds more_subfields_xml
to deleteditems - the reverted patch would attempt to add
more_subfields_xml to deleteditems twice for anybody
upgrading from < 048.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More problems with old_issues.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Assigning bug 1835 : change password would never log password change.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Using old_issues table

need some testing on data since I donot have valid data in my fresh created database.

Note : Shouldnot updatedatabase also cope with data "moving"
when a table is created and that some data should go from one table to another ?

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

CleanBorrowers fixing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Updatedatabase UPDATE For more_subfields_xml to be added to deleteditems at the same time as it is to items.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

borr_issues_top : adapting to old_issues changes

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug Fix : 1898 Replaces the previous commit : More fixes.

A) Fixing queries which were mysql old style
B) Fixing output.

+ Fixing queries the same way for bor_issues_top catalogue_out and issues_avg_stats

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing item-level_itype =ON imageurl in opac-detail.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

refactor C4::Log::logaction

This fix should resolve in whole or in part several bugs
characterized by the error message 'Can't use string ("0")
as a HASH ref while "strict refs" in use', including
bugs 1101, 1899, and 1910.

There are some possibilities for future work:

[1] Dealing with an operator override, e.g., where
    a circ operator needs to get a supervisor
    to enter a login and password and escalate
    the original operator's privileges for a
    transaction, e.g., to forgive a fine.  This
    is an enhancement, of course.
[2] Creating a dummy operator to represent
    batch job runs; or alternatively, give
    each batch job an option to log its work
    under a specified user ID.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Cleanup of z39.50 search form, addition of checkall js. Addition of tablesorter js to z39.50 results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed create table statement for patroncards

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding tablesorter

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bugfix for table sorting

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding tablesorter

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Partial fix for Bug 1949, Bibliographic Address isn't properly displayed on OPAC result page. Changes will have to be made to script to prevent display of pipes between subfield repeitions.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for Bug 1951, OPACURLOpenInNewWindow doesn't do anything.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Formatting and adding additional info to display of editions in the OPAC and the staff client.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Tweak to table-sorter css.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bugfix to correct date format in query used in GetLogs()

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Correcting Logging on ModMember function so that the query is logged in the 'info' field.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changing default value for yuipath to local rather than http

Setting this as a Choice parameter.
This may raise not a performance issue.
Since we were told that loading it local could be longer than getting it from yahoo.
But for poor internet connectivity, it would be a better.
For mobile computer, it is a better choice.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

don't include the item itself as an edition

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a <meta> field to make Koha's OPAC discoverable

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing where the 505 subfields are indexed (before the field) in record.abs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing bug 1801

adding some parameters to the call to opac-auth.tmpl in C4::Auth::checkauth
This displays the additional navigational links in the masthead on the login page to unauthenticated users.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixes bug 1924: Language selection lists English only and that several times.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

partial fix for bug 1873: virtualshelfcontents dateadded column empty

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

partial fix for bug 1891

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1625: Pass title, subtitle, and author variables to MARC views

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1781 for NOZebra=OFF

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

only show item-leve_itypes if syspref is set

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing itemtype image where item-level_itypes is OFF

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

remove warnings from Languages.pm

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Mod C4::Labels::add_batch to accept an array of items.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Partial commit to add Create-Label-Batch-from-Import-Batch

Import batch portion herein. Still need to touch Labels.pm .

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing bug 1754: Hide language chooser if only one translation is available

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

repairing faulty updatedatabase syntax

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bumping DB ver to 065

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Eighth installment Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Seventh installment Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Sixth installment Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fifth installment Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fourth installment Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Third installment Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Second Installment: Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

First installment: Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for 1610: Redirect to result when opac search returns only one item

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing nomenclature of vshelves

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing display of itemtypes and itemtype icons in virtual shelves

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1855: Language in News

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1925: 505 Field Indexing

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Add MARC preview to Z39.50 search.

Also, add title string to MARC editor.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Remove Z3950 mandatory fields from MARC editor.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Add z39.50 search form distinct from MARC editor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

wrapping dates in amazon ratings with format_date()

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1593: Fix item type image handling in OPAC

Also cleans up dates in a couple places

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More tweaks to shelf browse and similar items.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Working on styling browse features, similar items.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for Bug 1939, OpacMainUserBlock not displaying with news.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Link correction in similar items block.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More js-based table sorting

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Refining table sort

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Testing jquery table sorting plugin

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Displaying borrowernumber under 'Library Use' heading with label 'Patron ID.' Partial fix for Bug 1944, Borrownumber needs to display for librarians.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>