]> git.koha-community.org Git - koha.git/log
koha.git
8 years agoBug 12072: DBRev 3.21.00.056
Tomas Cohen Arazi [Thu, 19 Nov 2015 23:15:03 +0000 (20:15 -0300)]
Bug 12072: DBRev 3.21.00.056

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 12072: Make datepicker and templates to be aware of dmydot format
Marc Véron [Wed, 18 Nov 2015 16:33:33 +0000 (17:33 +0100)]
Bug 12072: Make datepicker and templates to be aware of dmydot format

This patch is to display corrextly the new dmydot date format e.g. after
using the datepicker or in messages for the user, in following files:

- koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
- koha-tmpl/intranet-tmpl/prog/en/includes/date-format.inc
- koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
- koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt
- koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc
- tools/holidays.pl

To test:
- Apply patch
- Make sure that you have syspref dateformat set to dmydot
- Use datepicker in OPAC (modify birth date), verify that after
  choosing a date, it is displayed correctly in the datepicker
- Use datepicker at several places in OPAC, verify that after choosing
  a date the date displays properly in datepicker and that the dater format
  is properly indicated (e.g. near birth date or near "Specify due date").
- Verify that datepicker works well with hoiday editing and that "From date:"
  displays properly

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 12072: Add system preference for New dateformat dd.mm.yyyy (dmydot)
Marc Véron [Sat, 7 Mar 2015 07:38:04 +0000 (08:38 +0100)]
Bug 12072: Add system preference for New dateformat dd.mm.yyyy (dmydot)

Note: This feature depends on Bug 14870 'Delete C4/Dates from system'

System preferences:
To test:
- apply the patch
- run updatedatabase.pl
- go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save
- verify that the value was saved

Date handling:
- go through the staff client and verify that dates behave as expected.
- go through Opac and verify that dates behave as expected.

  The Bugs where Bug 14870 depends on contain test plans that can be
  used for the overall testing.

Note: Make sure that you reset the dateformat to the former value after
      testing.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Works as expected

Amended to apply on top of Bug 15166 11.11.2015/mv

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14870: QA follow-up - fixing tiny typo
Katrin Fischer [Thu, 19 Nov 2015 13:47:43 +0000 (14:47 +0100)]
Bug 14870: QA follow-up - fixing tiny typo

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14870: (followup) Remove superfluous C4::Dates from fix_accountlines_rmdupfines_b...
Marc Véron [Wed, 18 Nov 2015 10:48:09 +0000 (11:48 +0100)]
Bug 14870: (followup) Remove superfluous C4::Dates from fix_accountlines_rmdupfines_bug8253.pl

This patch removes C4::Dates from fix_accountlines_rmdupfines_bug8253.pl

To test:
- Apply patch
- Check code for uses of C4::Dates (date_format)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14870: (followup) Remove stray C4::Dates
Marc Véron [Wed, 18 Nov 2015 07:57:27 +0000 (08:57 +0100)]
Bug 14870: (followup) Remove stray C4::Dates

(See comment #23)

This patch removes stray C4::Dates (date_fromat...) from
C4/Items.pm
C4/Log.pm
C4/Serials.pm
serials/acqui-search-result.pl
t/DateUtils.t
t/db_dependent/Items/GetItemsForInventory.t
tools/koha-news.pl

Some of them were inside comments etc.

To test:
- git grep 'C4::Dates' should give no result
- git grep 'format_d' should give no result
  Exception: in one cron job there exists an own sub format_date, and occurences not
             related to C4::Dates
- Search for regressions

http://bugs.koha-community.org/show_bug.cgi?id=14870
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
serials/acqui-search-results.pl looks like it should be revisited,
containing code that might not be needed. Searching a vendor
in serials still works witout a problem.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14870: (followup) Remove mention of C4::Dates from C4/Debug.pm
Marc Véron [Sun, 8 Nov 2015 22:26:25 +0000 (23:26 +0100)]
Bug 14870: (followup) Remove mention of C4::Dates from C4/Debug.pm

C4::Dates is mentioned as example in C4/Debug.pm. This patch removes it.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14870: (followup) Remove stray C4::Dates from reports files
Marc Véron [Sun, 8 Nov 2015 22:09:10 +0000 (23:09 +0100)]
Bug 14870: (followup) Remove stray C4::Dates from reports files

This patch removes stray C4::Dates from following files:

reports/borrowers_stats.pl
To test: Verify that C4::Dates is not used in the file

reports/guided_reports.pl:
To test:
- Run a saved report with date input and with date range input, e.g.
- Verify that you are asked for date range or date and that the results
  are the same as without patch

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14870: (followup) Remove stray C4::Dates from circ/returns.pl
Marc Véron [Sun, 8 Nov 2015 21:14:59 +0000 (22:14 +0100)]
Bug 14870: (followup) Remove stray C4::Dates from circ/returns.pl

This patch removes 1 remaining / stray occurence of C4::Dates from
circ/returns.pl

To test:
- Apply patch
- Go to Home > Circulation > Check in
- Verfiy that check-ins with overriding return dates work as before.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14870: Remove C4::Dates from plack.psgi and koha.psgi
Hector Castro [Sun, 8 Nov 2015 03:43:56 +0000 (21:43 -0600)]
Bug 14870: Remove C4::Dates from plack.psgi and koha.psgi

Remove C4::Dates from .psgi files from preloaded modules, placing
Koha::DateUtils instead

http://bugs.koha-community.org/show_bug.cgi?id=14870
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14870: Remove t/Dates.t from Koha
Hector Castro [Sat, 7 Nov 2015 16:56:23 +0000 (10:56 -0600)]
Bug 14870: Remove t/Dates.t from Koha

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14870: Remove C4/Dates.pm from Koha
Hector Castro [Fri, 6 Nov 2015 16:42:53 +0000 (10:42 -0600)]
Bug 14870: Remove C4/Dates.pm from Koha

http://bugs.koha-community.org/show_bug.cgi?id=14870
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15208: Followup to reorder words
Bernardo Gonzalez Kriegel [Wed, 18 Nov 2015 13:44:03 +0000 (10:44 -0300)]
Bug 15208: Followup to reorder words

It think it's better to put the shelf name first

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15208: Ease translation for shelves messages
Bernardo Gonzalez Kriegel [Wed, 18 Nov 2015 13:18:14 +0000 (10:18 -0300)]
Bug 15208: Ease translation for shelves messages

This string patch only puts <span>...</span>
around shelves messages. It split a monster
translation string into its components.
This kind of string to translate is error-prone.

Also fixed a typo on opac, 'deleteing'

To test:
1) Search for 'An error occurred when updating this list'
on your preferred language translation file for staff
or opac
(xx-YY-staff-prog.po or xx-YY-opac-bootstrap.po)
You will see a 'big' string to translate

2) Apply the patch

3) Update translation files for your language

4) Search again, big one is gone and there are
new individual strings to translate.

Sorry for not spotting this before string freeze

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15199: t/db_dependent/Review.t should not depend on existing data
Tomas Cohen Arazi [Tue, 17 Nov 2015 13:20:39 +0000 (10:20 -0300)]
Bug 15199: t/db_dependent/Review.t should not depend on existing data

This patch makes the tests create a branch and a patron category instead
of searching for them on the DB.

To test:
- Apply the patch on current master
- Run
  $ prove t/db_dependent/Review.t
=> SUCCESS: Tests pass
- Sign off

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
All test pass successful

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14954: Remove unused C4::Calendar::addDate subroutine
Jonathan Druart [Wed, 11 Nov 2015 12:59:44 +0000 (12:59 +0000)]
Bug 14954: Remove unused C4::Calendar::addDate subroutine

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14954: (followup) Display exceptions in syspref format
Marc Véron [Wed, 4 Nov 2015 15:05:59 +0000 (16:05 +0100)]
Bug 14954: (followup) Display exceptions in syspref format

This patch fixes the display of exceptions (was iso, is now syspref).
See comment #14 and attachment #15

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14954: (followup) Remove C4::Dates from holiday related files
Marc Véron [Wed, 28 Oct 2015 22:51:45 +0000 (23:51 +0100)]
Bug 14954: (followup) Remove C4::Dates from holiday related files

Followup for comment #10

To test:
- Go to Home > Tools > Calendar
- Add, edit, delete the different types of holidays and exceptions
- git grep 'C4::Calendar' and test such files
- git grep daysBetween to make sure that this sub is not used
- prove t/Calendar.t

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14954: Remove C4::Dates from holiday related files in folder tools
Marc Véron [Sun, 4 Oct 2015 20:31:40 +0000 (22:31 +0200)]
Bug 14954: Remove C4::Dates from holiday related files in folder tools

This patch removes C4::Dates from:
Remove C4::Dates from:

- tools/exceptionHolidays.pl
- tools/holidays.pl
- tools/newHolidays.pl
- C4/Calendar.pm

To test:
- Go to Home > Tools > Calendar
- Add, edit, delete the different types of holidays and exceptions
- git grep 'C4::Calendar' and test such files
- prove t/Calendar.t

(Amended following comments #3 and #4 / mv)
(Amended following comment #7 / 25.10.2015 / mv

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
http://bugs.koha-community.org/show_bug.cgi?id=14945
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14946: Remove C4::Dates from acqui/* files
Jonathan Druart [Tue, 10 Nov 2015 17:42:44 +0000 (17:42 +0000)]
Bug 14946: Remove C4::Dates from acqui/* files

This patch replaces all use of C4::Dates with Koha::DateUtils, which is
the best practice to follow.

It also fixes a bug on the invoice search, the shipment date (from and
to) were not passed correctly from one page to the other.

Test plan:
1/ Search for orders using the different filters
2/ Create an invoice, try with setting and leaving empty the date
fields.
Default should be an undefined value (not today)
3/ Search for invoices and use the 4 different filters.
Close and reopen invoices.
The filters should be kept from one page to the other (not that it does
not work with shipment date before this patch).
4/ Receive an order, on creating the invoice, the default date should be
today.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoChangelog update for 3.22.00~beta
Robin Sheat [Wed, 18 Nov 2015 02:33:41 +0000 (15:33 +1300)]
Changelog update for 3.22.00~beta

8 years agoBug 15168: (followup) remove useless diags
Tomas Cohen Arazi [Tue, 17 Nov 2015 18:47:46 +0000 (15:47 -0300)]
Bug 15168: (followup) remove useless diags

While testing this bug I noticed the tests printed useless diags.
This patch removes them for good.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14960: Simplify the date management in staticfines
Jonathan Druart [Wed, 11 Nov 2015 12:31:12 +0000 (12:31 +0000)]
Bug 14960: Simplify the date management in staticfines

There is no need to create a DT objcet, then display in string/iso
then recreate a DT object from this string.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14960: Remove C4::Dates from files in misc/cronjobs
Marc Véron [Mon, 5 Oct 2015 16:20:57 +0000 (18:20 +0200)]
Bug 14960: Remove C4::Dates from files in misc/cronjobs

This patch removes C4::Dates from following files:

- misc/cronjobs/batch_anonymise.pl
- misc/cronjobs/cleanup_database.pl
- misc/cronjobs/gather_print_notices.pl
- misc/cronjobs/serialsUpdate.pl
- misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl
- misc/cronjobs/overdue_notices.pl
- misc/cronjobs/staticfines.pl

To test:
- Carefully review code changes.
- Verify that the cronjobs behave as before.

Amended to make patch apply and follwoing comments on IRC by putti
http://irc.koha-community.org/koha/2015-11-06#i_1752803
(misc/cronjobs/gather_print_notices.pl is using still C4::Dates, line 84)
6.11.2015 /mv

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14969: (followup) Today's date withoute time when receiving
Marc Véron [Thu, 12 Nov 2015 09:47:09 +0000 (10:47 +0100)]
Bug 14969: (followup) Today's date withoute time when receiving

To test: Change status of a serial from Expected to Received,
         today's date in column "Expected" should appear without time.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14969: Remove C4::Dates from serials/*.pl files
Jonathan Druart [Wed, 11 Nov 2015 10:48:36 +0000 (10:48 +0000)]
Bug 14969: Remove C4::Dates from serials/*.pl files

Warning: This area is a mess, especially with date management.

For the same reasons as other "Remove C4::Dates from*" patches, this one
will deal with the serials module.

Note that this patch add the datepicker on 3 input fields (on
serials/subscription-detail.tt and serials/subscription-renew.tt).
There was also weird behavior when the dates were invalid. Now default
to undefined. But with the datepicker it will reduce the number of
cases even if the user is still allowed to fill invalid dates.

Test plan:
1/ Create a subscription, fill the first issue pub date and the
subscription start date.
You can fill or not the end date.
Play with the numbering pattern and confirm that there are generated as
before this patch.
2/ On the check expiration page, confirm that the dates are correctly
displayed.
3/ Renew the subscription and confirm that the behavior is correct.
4/ Go on the subscription history page and confirm you have now the
datepicker plugin set on the 2 date fields.

QA notes: The startdate, histstartdate and enddate are not used in
the serials-collection template, this patch removes them from the pl
script.

Tested on top of 15166 15168 15171, full browser reload for date pickers.
Note for 4/: It is the link in tab planning on subscription
detail page, near "Manual history" (if manual history is enabled).
Works as advertised.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15168: Remove C4:Serials::ItemizeSerials
Jonathan Druart [Wed, 11 Nov 2015 08:54:12 +0000 (08:54 +0000)]
Bug 15168: Remove C4:Serials::ItemizeSerials

This subroutine has been introduced in 2006, when C4::Serials has been
added to the codebase.
If you checkout this commit
commit 18d2cd099085e443d713a1546e029faa81481814
Date:   Fri Jul 7 08:45:47 2006 +0000
    this file replace C4/Bull.pm

You won't find any occurrences of this subroutine neither.

Interesting module's name by the way.

Test plan:
  git grep ItemizeSerials
should not return any result

Followed test plan, no results found.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15159: TestBuilder behaviour on AI values should be tested
Tomas Cohen Arazi [Mon, 9 Nov 2015 14:15:36 +0000 (11:15 -0300)]
Bug 15159: TestBuilder behaviour on AI values should be tested

This patch introduces a test for t::lib::TestBuilder to check it
doesn't mess with AI values. As it is generating random values based
on the defined column type, chances are that it is creating the
AI values on its own, instead of letting the DB handle it.

This could be problematic of course. This test uses the 'biblio' table
by creating two values and checking their biblionumbers are consecutive.

To test:
- Apply the patch
- Run:
  $ prove t/db_dependent/TestBuilder.t -v
=> SUCCESS: The new tests are run and:
   - biblio.biblionumber is detected as an auto-increment column
   - generated biblionumbers are consecutive
- Sign off

Regards

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
All tests successful.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15185: Remove Check*Holidays subroutines in C4::Circulation
Jonathan Druart [Fri, 13 Nov 2015 11:43:36 +0000 (11:43 +0000)]
Bug 15185: Remove Check*Holidays subroutines in C4::Circulation

These 3 subroutines are not used anymore:
- CheckRepeatableHolidays
- CheckSpecialHolidays
- CheckRepeatableSpecialHolidays

Moreover we have subroutines in Koha::Calendar to do this job.

Test plan:
  git grep CheckRepeatableHolidays
  git grep CheckSpecialHolidays
  git grep CheckRepeatableSpecialHolidays
should not return any results.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Subroutines removed

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 10067: decreaseLoanHighHolds messes with specify due date
Eivin Giske Skaaren [Mon, 25 May 2015 17:10:54 +0000 (17:10 +0000)]
Bug 10067: decreaseLoanHighHolds messes with specify due date

To test:

1. On a branch up to date with master: apply the patch.

2. Try to check out items both with and without holds.
(The decreaseLoanHighHolds function should be configured and kick in when testing an item.

3. Expected results are:
The due date date field should be cleared after checkout if "Remember for session"
is not selected. If it is selected then the chosen date should stay in the field even
if the warning about reduced loan time for an item with too many holds is displayed.
Also the correct due dates are shown in the table after a checkout.

Known limitation: Does not work too well when jumping between different parts
of the system as it relies on the values sent to the circulation.pl script.

Sponsored-by: Halland County Library
Refactored to both fix specific issue where date is changed
and still have the old behaviour with date kept intact.

Rebase
Remove code whitespace cleanup

Remove one more code whitespace cleanup

Removed duplicate tag

Refactored stickyduedate session parameter

Fix datefield set by highholds if blanc

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15175: Respect IntranetBiblioDefaultView syspref
Frédéric Demians [Wed, 11 Nov 2015 17:59:35 +0000 (18:59 +0100)]
Bug 15175: Respect IntranetBiblioDefaultView syspref

Respect IntranetBiblioDefaultView on intra search result page, on cover image
link, when XSLTResultsDisplay is empty.

TO TEST:

1. Empty XSLTResultsDisplay
2. Activate intranet local and Amazon cover images
3. Play changing IntranetBiblioDefault, and observe the links respectively on
   biblio record title and cover image. Title's link is OK, cover image
   link goes to detail.pl page independently of IntranetBiblioDefault.
4. Apply the patch.
5. Repeat 3.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Link to right display according with IntranetBiblioDefaultView is fixed.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
http://bugs.koha-community.org/show_bug.cgi?id=14175
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15070: Update MARC21 it-IT frameworks to Update 21 (September 2015)
Zeno Tajoli [Wed, 11 Nov 2015 14:00:36 +0000 (15:00 +0100)]
Bug 15070: Update MARC21 it-IT frameworks to Update 21 (September 2015)

To test it:

- drop and recrate Koha DB
- Run the Koha web installer for it-IT
- Run MARC bibliographic framework test

http://bugs.koha-community.org/show_bug.cgi?id=15070

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested with it-IT installer
All files load without problem, save for FastAdd (see Bug 15181)
but the file loads Ok

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15171: Display subscriptions which will expire in the future
Jonathan Druart [Wed, 11 Nov 2015 09:36:16 +0000 (09:36 +0000)]
Bug 15171: Display subscriptions which will expire in the future

Since the form on the subscription check expiration page let the user choose an
expiration date > today, there is no sense to hide subscriptions which will expire in the future.

Test plan:
0/ Make sure you have at least subscription with an expiration date > today
1/ Start a seach on the check expiration page (serials/checkexpiration.pl)
with a date < today, = today and > today
=> The subscription won't never be displayed without this patch.
With this patch, it will.

Note that you will get a "No results for your query" message only if you
have search for something.

Followed testplan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15114: Fix typo in opac-suggestion template
Jonathan Druart [Fri, 13 Nov 2015 15:45:04 +0000 (15:45 +0000)]
Bug 15114: Fix typo in opac-suggestion template

There is a $ in front of the loggedinusername variable, which is
obviously not what is expected here.

It fixes the wrong warning message "You are not authorized to see
pending purchase suggestions." when it should be "There are no pending
purchase suggestions."

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15189: Do not close STDERR when running in background mode
Jonathan Druart [Fri, 13 Nov 2015 16:22:03 +0000 (16:22 +0000)]
Bug 15189: Do not close STDERR when running in background mode

The batch records modification tool close STDERR, it's useless and hide
warnings/errors.

Like the other processes using the BackgroundJob module, this one should
let it open.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15109: Make name the default sort order for all patron searches
Jonathan Druart [Fri, 13 Nov 2015 09:18:43 +0000 (09:18 +0000)]
Bug 15109: Make name the default sort order for all patron searches

Find another place where there is a patron search (add user to a basket,
add users to a fund or edit owner of a fund, set a guarantor to a child,
etc.).
Do a search a confirm that the results are now sorted by name instead of
cardnumber.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15109 - Regression in patron search results ordering
Jonathan Druart [Fri, 13 Nov 2015 09:17:49 +0000 (09:17 +0000)]
Bug 15109 - Regression in patron search results ordering

In Koha 3.16 or earlier, before the introduction of the ajax datatable
for patron searching, the search results were ordered by name. In
master, the results are currently ordered by cardnumber, which is not
very useful.

Test Plan:
1) Do a "browse by last name" or a patron search
2) Note the results are sorted by card number
3) Apply this patch
4) Reload the page, start a new search
5) Note the results are sorted by name

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15197: In Rancor, multiple &/</" characters not escaped on saving
Jesse Weaver [Tue, 10 Nov 2015 19:12:43 +0000 (12:12 -0700)]
Bug 15197: In Rancor, multiple &/</" characters not escaped on saving

Test plan:

  1) On current master, create a record in Rancor containing multiple &, < or " characters ("A & B & C", for example).
  2) Try to save the record, it will silently fail.
  3) Apply this patch.
  4) The record should now save correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works well, record saved
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15182: Conditionally load Koha::NorwegianPatronDB
David Cook [Tue, 17 Nov 2015 01:36:16 +0000 (12:36 +1100)]
Bug 15182: Conditionally load Koha::NorwegianPatronDB

This patch loads Koha::NorwegianPatronDB if it can, or adds a warning
to the log if it can't load it.

Since the Koha::NorwegianPatronDB functionality in C4::Members is
wrapped in system preferences, the loading of the module is
irrelevant unless one actually wants to use the module and its
associated functionality.

NOTE:

This patch fixes a problem where we were getting errors saying
Crypt::GCrypt couldn't be loaded even though it's not a required
dependency.

This patch will likely only affect people not using Debian-based
systems where libcrypt-gcrypt-perl is available. The current
version of Crypt::GCrypt doesn't build so it's not an option
for most non-Debian users to install this not required
dependency in order to work around this issue...

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised for Debian-based systems

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15152: t/db_dependent/Reports_Guided.t should not depend on existing data
Tomas Cohen Arazi [Mon, 16 Nov 2015 18:25:26 +0000 (15:25 -0300)]
Bug 15152: t/db_dependent/Reports_Guided.t should not depend on existing data

The current implementation relies on existing borrowers on the DB.
Even when the DB itself doesn't have a FK constraint, the function
that retrieves the reports from the DB relies on get_saved_reports_base_query
which creates a query that JOINs the full query with the 'borrowers' table, on
the borrowernumber. So it is doomed to fail on some scenarios.
Specially because the current tests expect specific borrowernumber values
to be present (1, 2 and 3).

To test:
[To set the failure scenario]
 $ vagrant up jessie
 $ vagrant ssh jessie
 $ wget https://theke.io/static/reports_guided_sequence.txt -O /vagrant/reports_guided_sequence.txt
 $ wget https://theke.io/static/koha_3_20_00.sql.gz -O /vagrant/koha_3_20_00.sql.gz
 $ sudo -s
 $ mysql
 > DROP DATABASE koha_kohadev; CREATE DATABASE koha_kohadev; \q
 $ zcat /vagrant/koha_3_20_00.sql.gz | mysql koha_kohadev
 $ exit
 $ sudo koha-shell kohadev
 $ cd kohaclone
 $ cat /vagrant/reports_guided_sequence.txt | xargs prove

- now run the tests:
 $ prove t/db_dependent/Reports_Guided.t
=> FAIL: The tests fail

- Apply the patch
- [re create the scenario]
- Run the test:
  $ prove t/db_dependent/Reports_Guided.t
=> SUCCESS: Tests now pass
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15133: encode correctly email generated by runreport.pl
Frédéric Demians [Thu, 5 Nov 2015 07:45:25 +0000 (08:45 +0100)]
Bug 15133: encode correctly email generated by runreport.pl

/misc/cronjobs/runreport.pl send badly encoded email in text/csv
(partially ok in HTML).

TEST:

1. Send by email a report containing a subject with accented characters
   and resultset with accented characters. For example:

   ./runreport.pl --subject="éèà" --to=me@home.org  1
   ./runreport.pl --format=html --subject="éèà" --to=me@home.org  1

   The first email contains badly encoded subject & message. The second email
   contains badly encoded subject, but correct message.

2. Apply the patch

3. Repeat 1 => No more strange characters.

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Characters are correctly encoded now, thanks for that good spot.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15120: runreport.pl cronjob doesn't allow custom subjects anymore
Liz Rea [Wed, 4 Nov 2015 02:33:40 +0000 (15:33 +1300)]
Bug 15120: runreport.pl cronjob doesn't allow custom subjects anymore

To test, well do something like

misc/cronjobs/runreport.pl --subject="My fancy subject!" --to=you@youraddress.com 1
where 1 is the number of your favourite saved report.

Success is your email arrives with the subject "My fancy subject!" Failure is
(with --subject defined) you get either the description of the report, or "Koha
saved report" as the subject. This is success without --subject defined.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Bug repeatable and fixed by this patch.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14542: Transliterate rule for all single quote forms
Fridolin Somers [Thu, 16 Jul 2015 15:48:14 +0000 (17:48 +0200)]
Bug 14542: Transliterate rule for all single quote forms

Single quotes in common language (not in programming) are usually ', but
there is also the form known as &rsquo; in HTML.  See
https://fr.wikipedia.org/wiki/Apostrophe_%28typographie%29

This bug proposes to transliterate all forms into a space.

Test plan :
(I'll use the code &rsquo; instead of the unicode character)
- Without the patch
- Create a record with title : L&rsquo;avion d&rsquo;argile
- Index this record
- Search for "L&rsquo;avion d&rsquo;argile" => You find the record
- Search for "L'avion d'argile" => You do not find the record
- Apply patch
- Search for "L&rsquo;avion d&rsquo;argile" => You find the record
- Search for "L'avion d'argile" => You find the record
- Search for "L avion d argile" => You find the record

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14544: Fix regression on sending an email from staff
Jonathan Druart [Fri, 13 Nov 2015 16:49:53 +0000 (16:49 +0000)]
Bug 14544: Fix regression on sending an email from staff

The shelfnumber was not filled and result in a software error
Can't call method "get_contents" on an undefined value at
/home/koha/src/virtualshelves/sendshelf.pl line 74.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Whith patch mail is sent.
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15116: Show menu at the top of batch circ page
Martin Stenberg [Thu, 5 Nov 2015 12:58:55 +0000 (13:58 +0100)]
Bug 15116: Show menu at the top of batch circ page

This patch adds the user interaction menu to the top of the batch
checkout page.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14078: (followup) converting from ISO5426 is not complete
Fridolin Somers [Wed, 29 Apr 2015 10:35:00 +0000 (12:35 +0200)]
Bug 14078: (followup) converting from ISO5426 is not complete

Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426().
Each character or combined characters conversion is defined in a map.

This patch adds missing conversions.

See http://www.gymel.com/charsets/MAB2.html

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14078: converting from ISO5426 is not complete
Fridolin Somers [Wed, 29 Apr 2015 10:24:23 +0000 (12:24 +0200)]
Bug 14078: converting from ISO5426 is not complete

Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426().
Each character or combined characters conversion is defined in a map.

This patch changes some odd actual conversions.

In char_decode5426(), only characters between 0xC0 and 0xDF will be used for combining with following charater :
  ($char >= 0xC0 && $char <= 0xDF)
So conversion like "$chars{0x81d1}=0x00b0" will never be used.
Rules for "h with breve below" use combining with 0xf9 but looks like the correct caracter is 0xd5.

See http://www.gymel.com/charsets/MAB2.html

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15154: Allow correct translation for upload local cover image
Hector Castro [Sat, 7 Nov 2015 06:16:02 +0000 (00:16 -0600)]
Bug 15154: Allow correct translation for upload local cover image

To test:
-Set syspref LocalCoverImages and OPACLocalCoverImages to Allow
-A new tab 'Images' appear in bib record detail on Intranet.
-Notice about the phrase "Please upload one"
-Apply the patch and reload the page.
-New phrase appear "Select the image file to upload" with button Upload
-Update translation files : cd misc/translator; perl translate update es-ES
-You will see in es-ES-staff-prog.po the new entry
"Select the image file to upload. %sUpload%s"
-You can see the result installing the translation
cd misc/translator ; perl translate install es-ES

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  A native English speaker could confirm that the wording is ok: Please select
  the image file to upload

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15137: Display ISBN and author info when sending list by email
Jonathan Druart [Fri, 13 Nov 2015 15:18:56 +0000 (15:18 +0000)]
Bug 15137: Display ISBN and author info when sending list by email

Disclaimer: this is not caused by bug 14544 :)
And can be backported!

Both isbn and author information are missing when a list is sent by
email.
Emails sent from OPAC and staff should be (almost) the same.

Test plan:
1/ Sent a list by email (Button "Send list")
2/ The email you will receive should contain the isbn and author info

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
On top of last patch of Bug 14544
Works ok, mail with authors and ISBN
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 6657: Prevent biblionumber to be duplicated
Jonathan Druart [Thu, 17 Sep 2015 13:31:55 +0000 (14:31 +0100)]
Bug 6657: Prevent biblionumber to be duplicated

If the biblionumber field is displayed in the framework, on editing a
biblio the field/subfield will be duplicated.
To prevent that this patch adds a check when building the field list.

Test plan:
1/ map biblio.biblionumber with 999$c
2/ Display 999$c in a framework
3/ Edit a biblio using this framework
4/ Save => The field should not have been duplicated

5/ map biblio.biblionumber with 001
6/ Display 001 in a framework
7/ Edit a biblio using this framework
8/ Save => The field should not have been duplicated

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works as described, aldo removes duplicate values.
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14795: Prevent modifying a record without using the original framework
Jonathan Druart [Fri, 13 Nov 2015 16:30:32 +0000 (16:30 +0000)]
Bug 14795: Prevent modifying a record without using the original framework

The origin framework is not passed on modifying the records and so the
default one is used.
This can caused data lost.

Test plan:
- Create a bibliographic record and specify a framework (not the default
one).
- Use the Batch records modification tools to modify it.
=> Without this patch, the default framework (framework code "") is used
and can deteriorate the record
=> With this patch, the record is saved using the original framework

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested framework is lost using tool without patch
Problem gone with patch
No qa errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15181: Rename marc21 fast add framework sql file
Bernardo Gonzalez Kriegel [Thu, 12 Nov 2015 16:43:33 +0000 (13:43 -0300)]
Bug 15181: Rename marc21 fast add framework sql file

This patch simply renames fast add sql file in order
to load this file before default framework.

To test:
1) Do a marc21 install (de,en,es,it)
load all sample files
check Fast Add framework is empty (no fields/subfields)

2) Apply the patch

3) Do an install again, this time FastAdd must have values.

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15058: Update German web installer sample files for 3.22
Katrin Fischer [Wed, 11 Nov 2015 23:45:04 +0000 (00:45 +0100)]
Bug 15058: Update German web installer sample files for 3.22

- Completes translations in German web installer sample files.
- Adds AddressFormat = German to the default system preference
  settings.

To test:
- Run the web installer in German with all sample files selected
- Confirm no error messages are shown
- Bonus: if you speak German, check spelling and translations

Signed-off-by: Zeno Tajoli <z.tajoli@cineca.it>
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15178: Update of Italian web installer .sql files for 3.22
Zeno Tajoli [Thu, 12 Nov 2015 11:57:05 +0000 (12:57 +0100)]
Bug 15178: Update of Italian web installer .sql files for 3.22

- iNot worked on notices.sql becouse there is a bug on it (Bz 15177)
- Some change in Italian default system preference settings.

To test:
- Run the web installer in Italian with all sample files selected
- Confirm no error messages are shown

http://bugs.koha-community.org/show_bug.cgi?id=15178

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Proofreading OK. Web installer OK. Tutto bene, grazie

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15079: Batch Delete Records Error
Kyle M Hall [Thu, 29 Oct 2015 11:48:02 +0000 (07:48 -0400)]
Bug 15079: Batch Delete Records Error

When using the batch deletion tool, if the script attempts to delete an
undeletable item, the script will die with the error:

Label not found for "next BIBLIONUMBER" at
/usr/share/koha/intranet/cgi-bin/tools/batch_delete_records.pl line 172.

Test Plan:
1) Attempt to batch delete a record with an item that cannot be deleted
2) Note error
3) Apply this patch
4) Repeat step 1
5) Note the error no longer occurs

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised. Follow comment 5 to reproduce the issue

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
I have not tested this patch, but looking at the code it is obviously a mistake.
If an error occured, we rollback and skip this record.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14985: dbms expects a iso formatted date
Jonathan Druart [Wed, 11 Nov 2015 14:26:51 +0000 (14:26 +0000)]
Bug 14985: dbms expects a iso formatted date

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14985: Simplify the date management in AddReserve
Jonathan Druart [Wed, 11 Nov 2015 12:07:05 +0000 (12:07 +0000)]
Bug 14985: Simplify the date management in AddReserve

The code is much more readable using the str param of output_pref

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14985: Fix regression on patron search
Jonathan Druart [Wed, 11 Nov 2015 12:03:51 +0000 (12:03 +0000)]
Bug 14985: Fix regression on patron search

This patch fixes 2 major errors introduced by last patch:
1/ Undefined subroutine &C4::Utils::DataTables::Members::dt_from_string
called
when searching for patrons
2/ Display the dates on the patron search in the pref format, not iso

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14985: Remove C4::Dates from files in folder C4/*.pm (part one)
Marc Véron [Thu, 8 Oct 2015 21:02:30 +0000 (23:02 +0200)]
Bug 14985: Remove C4::Dates from files in folder C4/*.pm (part one)

This patch removes C4::Dates from following files in folder C4:

- C4/Members.pm
- C4/Reserves.pm
- C4/Search.pm
- C4/Utils/DataTables.pm
- C4/Utils/DataTables/Members.pm
- C4/VirtualShelves/Page.pm

To test:
 -run tests as appropriate,
- have a close look at the code changes
- try to find regressions

http://bugs.koha-community.org/show_bug.cgi?id=14985

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Bug 14985: (followup) Remove eval if dates come from database

This patch removes some evals from date-formatting where the dates come
from the database.

See comments #7 - #9

Additionaly, C4/VirtualShelves/Page.pm is removed from the patches (obsolete).

Bug 14985: (followup) Remove C4::Dates from C4/Overdues.pm

Ths patch removes a stray C4::Dates from C4/Overdues.pm

- To test got to a patron who has overdues
  (Home > Circulation > Checkouts > [Patron])
- Print overdues

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15166: Carp if an invalid date is passed
Jonathan Druart [Wed, 11 Nov 2015 11:55:05 +0000 (11:55 +0000)]
Bug 15166: Carp if an invalid date is passed

Sign-off on second patch.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15166: Make output_pref takes a string in parameter
Jonathan Druart [Tue, 10 Nov 2015 16:38:51 +0000 (16:38 +0000)]
Bug 15166: Make output_pref takes a string in parameter

To simplify the management of dates, it would be great that output_pref takes a string in parameter.

  my $date = $input->param('my_date');
  $date = eval { dt_from_string( $date ) } if $date;
  $date = output_pref({dt => $date}) if $date;

Could be replace with:

  my $date = output_pref({ str => $input->param('my_date') });

Tested with t/DateUtils.t, passed OK.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14915: (follow-up) [FA 4.4] (QA followup) Replace fa-hold with fa-sticky-note-o
Jonathan Druart [Fri, 13 Nov 2015 14:16:04 +0000 (14:16 +0000)]
Bug 14915: (follow-up) [FA 4.4] (QA followup) Replace fa-hold with fa-sticky-note-o

Reported on bug 15186.

Test plan:
Do a search on the staff interface
You will get an error in the console and the image + checkboxes are not
display.

With this patch it will be fixed.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoKoha 3.22 beta v3.22.00-beta
Tomas Cohen Arazi [Thu, 12 Nov 2015 13:08:51 +0000 (10:08 -0300)]
Koha 3.22 beta

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoPreliminary (beta) release notes for 3.22
Tomas Cohen Arazi [Thu, 12 Nov 2015 13:05:50 +0000 (10:05 -0300)]
Preliminary (beta) release notes for 3.22

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15177: Add missing coma in ru-RU
Jonathan Druart [Thu, 12 Nov 2015 12:55:08 +0000 (12:55 +0000)]
Bug 15177: Add missing coma in ru-RU

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15177: TO_PROCESS notice for fr-FR
Frédéric Demians [Thu, 12 Nov 2015 06:46:58 +0000 (07:46 +0100)]
Bug 15177: TO_PROCESS notice for fr-FR

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15177: Sample notice TO_PROCESS confuses budget and fund
Katrin Fischer [Wed, 11 Nov 2015 23:22:00 +0000 (00:22 +0100)]
Bug 15177: Sample notice TO_PROCESS confuses budget and fund

Changes budget to fund in all TO_PROCESS notices but the
German sample file.

The German sample file will be dealt with in a separate patch.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoTranslation updates for Koha 3.22.0-beta release
Bernardo Gonzalez Kriegel [Tue, 10 Nov 2015 18:25:58 +0000 (15:25 -0300)]
Translation updates for Koha 3.22.0-beta release

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 7143: Add Marc Veron to the release team
Tomas Cohen Arazi [Wed, 11 Nov 2015 22:00:48 +0000 (19:00 -0300)]
Bug 7143: Add Marc Veron to the release team

During this release cycle he worked really hard looking for things to fix.
He's a brave bug wrangler and his name should be on the credits for 3.22.
Period.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Well deserved.

8 years agoBug 13799: (PM followup) Dependency updates
Robin Sheat [Wed, 11 Nov 2015 03:26:42 +0000 (16:26 +1300)]
Bug 13799: (PM followup) Dependency updates

Added new rependencies.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15102: Fix capitalization for some strings on XSLT detail pages
Hector Castro [Sun, 8 Nov 2015 05:59:23 +0000 (23:59 -0600)]
Bug 15102: Fix capitalization for some strings on XSLT detail pages

To test:
-Search records with 336, 337, 338, 700$i, and 7XXind=2
-Search records with 508, 264Ind=4, 246, 856, and LDR/6 and
LDR/7 (BK, VM, CR, CF)
-Notice the capitalization (Contained Works, Related Works, Media Type,
Content Type, and Carrier Type, Production Credits, Copyright Date,
Other Title, Online Access, Continuing Resource, Mixed Materials,
Computer File, Visual Material) in both OPAC and Intranet for
records detail pages and results pages
-Apply this patch
-Search again and get notice about the capitalization following
Koha coding guidelines

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14553: Silencing warn triggered when clearing item rating on OPAC
Aleisha [Tue, 21 Jul 2015 18:38:58 +0000 (18:38 +0000)]
Bug 14553: Silencing warn triggered when clearing item rating on OPAC

To test:

1) Go to any item and clear the star rating (don't have to set a rating first)
2) Notice the warn
3) Apply patch and reload page
4) Clear star rating
5) Notice no warn
6) Click a star to add a rating
7) Make sure your rating, the average rating and amount of votes are all
   correct
8) Could be beneficial to log in as another user and try to add a rating on the
   same item from their account. Check the average rating is
   cacalculated and amount of votes increases
9) Confirm still no warns

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Can see the warning in logs, and its disappearance with this patch.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14998: Restore previous behavior
Jonathan Druart [Wed, 11 Nov 2015 12:40:52 +0000 (12:40 +0000)]
Bug 14998: Restore previous behavior

We want to convert a us or metric date formatted to the format defined in
the pref.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14998: Remove C4::Dates from installer and maintenance folders
Marc Véron [Sat, 10 Oct 2015 09:38:20 +0000 (11:38 +0200)]
Bug 14998: Remove C4::Dates from installer and maintenance folders

- installer/data/mysql/updatedatabase.pl
- misc/maintenance/fix_accountlines_date.pl

To test for updatedatabase.pl

- perl installer/data/mysql/updatedatabase.pl
- review code. Difficult to test, because the code affects
  $DBversion = '3.03.00.035'

To test for misc/maintenance/fix_accountlines_date.pl
 - review code
 - The file seems to be a file used for an update, could it be obsolete?
   If yes, remove it in a follow-up

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Code OK. Tested updatedatabase.pl with an old DB backup: OK.
  fix_accountlines_date.pl still working after the patch. Could be removed from
  master IMO.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14544: Remove debug line
Jonathan Druart [Wed, 11 Nov 2015 13:19:22 +0000 (13:19 +0000)]
Bug 14544: Remove debug line

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15097: Update MARC21 de-DE frameworks to Update 21 (September 2015)
Katrin Fischer [Sun, 1 Nov 2015 14:43:42 +0000 (15:43 +0100)]
Bug 15097: Update MARC21 de-DE frameworks to Update 21 (September 2015)

Updates the framework files using the po file based mechamism
provided by Bernardo.

To test:
- Check that changes make sense
- Run the Koha web installer for de-DE
- Confirm all 4 files changed here load without errors

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
All files load without errors, pass marc bibliographic fw test
No errors
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14735: Save cache_expiry on modifying a report
Jonathan Druart [Tue, 10 Nov 2015 15:17:12 +0000 (15:17 +0000)]
Bug 14735: Save cache_expiry on modifying a report

The cache_expiry is not saved when updating a SQL report.

Test plan:
0/ Enable memcached
1/ Create a sql report
2/ Edit it and change the cache expiry value
3/ Edit again
=> The value should have been updated.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Repeatable bug. Solved with this patch.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 7895: Test for PSGI-related env to report in about.pl
Tomas Cohen Arazi [Wed, 21 Oct 2015 01:50:47 +0000 (22:50 -0300)]
Bug 7895: Test for PSGI-related env to report in about.pl

This patch introduces a test for psgi/plack in %ENV and uses that data
to report in the about page.

To test:
- On current master (without Plack), go to about.pl
- Notice no mention of Plack
- Apply the patch
- Reload the about page
=> SUCCESS: No change
- Enable plack, and access the about page through Plack
=> SUCCESS: There is a PSGI label, showing that you are running Plack
- Sign off :-D

Regards

PS: I haven't tested the mod_perl scenario, I just grabbed the MOD_PERL env var
from the docs.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15011: koha-indexer should define the --pidfiles on starting the daemon
Jonathan Druart [Wed, 14 Oct 2015 13:20:38 +0000 (13:20 +0000)]
Bug 15011: koha-indexer should define the --pidfiles on starting the daemon

The --pidfiles options is not provided on starting the daemon and the is_indexer_running consider that the daemon is not running

Test plan:
koha-indexer start
koha-indexer stop

should start and stop the zebra daemon wuthout any error.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Tested on kohadevbox:ansible

sudo debian/scripts/koha-indexer --stop kohadev
sudo debian/scripts/koha-indexer --start kohadev
sudo debian/scripts/koha-indexer --restart kohadev

All work as expected on the different scenarios.

8 years agoBug 7143: Updates for the 3.22 release
Tomas Cohen Arazi [Tue, 10 Nov 2015 13:51:16 +0000 (10:51 -0300)]
Bug 7143: Updates for the 3.22 release

This patch adds the new devs missing from the history.txt file
that contributed patches during the 3.22 release cycle. It fixes
the missing ones on the about page too.

Bonus: Adds Olli, who was missing, so numbering shift was needed too.
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14575: Fix typo in opac-basket.tt
Jonathan Druart [Tue, 10 Nov 2015 09:06:32 +0000 (09:06 +0000)]
Bug 14575: Fix typo in opac-basket.tt

No more typo in the codebase.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14575: Fix typo OPACurlOpenInNewWindow vs OPACURLOpenInNewWindow
Jonathan Druart [Mon, 9 Nov 2015 11:01:02 +0000 (11:01 +0000)]
Bug 14575: Fix typo OPACurlOpenInNewWindow vs OPACURLOpenInNewWindow

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14575: OPACURLOpenInNewWindow should apply to item-level urls too
David Cook [Tue, 21 Jul 2015 03:09:39 +0000 (13:09 +1000)]
Bug 14575: OPACURLOpenInNewWindow should apply to item-level urls too

This patch applies the OPACURLOpenInNewWindow system preference
to item-level urls (in addition to the pre-existing bib-level url
handling).

_TEST PLAN_

Before applying:

1) Set OPACURLOpenInNewWindow to "don't" and click on an item-level url
2) Note that the current tab changes to that url
3) Set OPACURLOpenInNewWindow to "do" and click on an item-level url
4) Note that the current tab changes to that url

Apply the patch.

After applying:

5) Click on an item-level url
6) Note that the url opens in a new tab (as OPACURLOpenInNewWindow
should be set to "do")
7) Set OPACURLOpenInNewWindow to "don't" and click on an item-level
url
8) Note that the url opens in the current tab

9) Repeat the above steps 5-8 alternating
"TrackClicks" between "Don't track" and either "Track" or
"Track anonymously".

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14743: addorder.pl redirect problems under plack behind apache 2.4.10
Kyle M Hall [Thu, 5 Nov 2015 13:24:51 +0000 (13:24 +0000)]
Bug 14743: addorder.pl redirect problems under plack behind apache 2.4.10

I can't quite figure this out. When I run CGI version of Koha, I see following response (recorded using tcpdump):

HTTP/1.1 302 Found
Date: Thu, 27 Aug 2015 13:28:41 GMT
Server: Apache/2.4.10 (Debian)
Location: /cgi-bin/koha/acqui/basket.pl?basketno=5610
Vary: User-Agent
Content-Length: 0
Keep-Alive: timeout=5, max=98
Connection: Keep-Alive
Content-Type: text/x-perl

However, when running behind apache 2.4.10 on Debian wheezy I see chunked response:

HTTP/1.1 302 Found
Date: Thu, 27 Aug 2015 13:21:28 GMT
Server: Apache/2.4.10 (Debian)
Vary: User-Agent
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Transfer-Encoding: chunked
Content-Type: text/x-perl

60
Transfer-Encoding: chunked
Date: Thu, 27 Aug 2015 13:21:28 GMT
Connection: keep-alive

0

0

This response doesn't work in firefox (where it reports page not found) nor in chrome (where it returns lines below 60 on screen).

In the template the hidden input 'basketno' is listed twice. What the cgi script reads in the parameter, what is does is concat the values of the multiple basketno instances together createing what is likely an invalid basketno. For reasons beyond my understanding this is what triggers this error!

Test Plan:
1) Using plack, add an order to a basket from an external source
2) Note the error
3) Apply this patch
4) Add an order to a basket from an external source
5) Note you get no error!

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15160: GetTopIssues.t should create random data
Tomas Cohen Arazi [Mon, 9 Nov 2015 14:35:03 +0000 (11:35 -0300)]
Bug 15160: GetTopIssues.t should create random data

This patch refactors t/db_dependent/Circulation/GetTopIssues.t so it
creates its own data with random values. It does so by replacing (legacy)
SQL inserts and fixed value data inserting by TestBuilder generated data.

There is no expected behaviour change.

To test:
- Create an itemtyp directly on your DB with GTI_I_TEST as its itemtype
  > INSERT INTO itemtypes (itemtype) VALUES ('GTI_I_TEST');
- Run:
  $ prove t/db_dependent/Circulation/GetTopIssues.t
=> FAIL: The insert line fails
- Apply the patch
- Run:
  $ prove t/db_dependent/Circulation/GetTopIssues.t
=> SUCCESS: tests pass due to random data usage.
- Sign off

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  Test plan produces the expected result, failing, then OK.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15036: Do not overwrite complete status in basket ops
Colin Campbell [Tue, 20 Oct 2015 13:19:35 +0000 (14:19 +0100)]
Bug 15036: Do not overwrite complete status in basket ops

Reopening or closing a basket should preserve the completed
status for receipted orders.

This patch excludes orderlines with the completed status
from having their status rewritten as a result of the
change in basket status

Made the subroutines involved more efficient by removing an
unnecessary loop and by not fetching a large amount of
superfluous data

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8064: DBRev 3.21.00.054
Tomas Cohen Arazi [Mon, 9 Nov 2015 18:13:03 +0000 (15:13 -0300)]
Bug 8064: DBRev 3.21.00.054

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8064: Fix unit tests for createMergeHash
Julian Maurice [Mon, 9 Jun 2014 07:55:28 +0000 (09:55 +0200)]
Bug 8064: Fix unit tests for createMergeHash

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8064: Little fix for 003, 005, 008 in MARC21
Stefano Bargioni [Tue, 11 Mar 2014 09:22:12 +0000 (10:22 +0100)]
Bug 8064: Little fix for 003, 005, 008 in MARC21

I found a little bug in the patch. Subfield '@' of tags 003, 005, 008 in
MARC21 were not correctly handled by function check_mandatory() in
merge.tt. I fixed the problem. In my opinion, the patch can be signed
off.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8064: Fix issues with control fields and non-repeatable check
Julian Maurice [Fri, 20 Dec 2013 10:01:09 +0000 (11:01 +0100)]
Bug 8064: Fix issues with control fields and non-repeatable check

Fields < 010 were systematically unchecked during target rebuild because
they have no subfields (unchecking manually all subfields of a field
automatically uncheck the field)
When user check a field or a subfield, we have to uncheck it before
calling (sub)field_can_be_added. Otherwise, field is treated as if it
was already in target record, and this is a problem for non-repeatable
fields.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8064: Change the way target record is built.
Julian Maurice [Wed, 6 Nov 2013 11:17:45 +0000 (12:17 +0100)]
Bug 8064: Change the way target record is built.

Instead of copying/removing a piece of DOM in target record each time a
checkbox is checked/unchecked, the target record is *entirely* rebuilt
each time a checkbox is checked/unchecked.
This is slower but allow for a more consistent and less error-prone
behaviour.

This patch also fix the mandatory check for subfields

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 8064: Merge several biblios
Julian Maurice [Tue, 28 May 2013 14:24:53 +0000 (16:24 +0200)]
Bug 8064: Merge several biblios

This patch improves the existing merging tool by adding possibility to
merge more than 2 biblios.
There is no functional changes:
  - Add some biblios to a list
  - In the list check some biblios and click on 'Merge selected records'
  - Choose the biblio which will be kept, all others will be deleted
  - On the next page you have all biblios you chose in tabs (left side
    of the screen) and the preview of result (right side)
  - Pick some fields or subfields from records that will be deleted or
    delete some fields from reference record.
  - Click on 'Merge', if there is no errors you are redirected to the
    biblio view.

Added checks for non-repeatable subfields
Added checks for mandatory fields and subfields before submitting the
form.
Added a final report which display deleted records (see syspref
MergeReportFields)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14402: (QA followup) Add notes to usage text about --fees
Kyle M Hall [Tue, 15 Sep 2015 12:28:45 +0000 (08:28 -0400)]
Bug 14402: (QA followup) Add notes to usage text about --fees

Added notes to usage in misc/cronjobs/cleanup_database.pl that
--fees DAYS requires DAYS to be greater than or equal to 1.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14402: Make purge_zero_balance_fees() delete fees with NULL balance.
Barton Chittenden [Thu, 10 Sep 2015 22:03:43 +0000 (22:03 +0000)]
Bug 14402: Make purge_zero_balance_fees() delete fees with NULL balance.

Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.

Signed-off-by: Nancy Keener <nkeener@washoecounty.us>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14402: Add option --fees to /misc/cronjobs/cleanup_database.pl
Barton Chittenden [Sat, 18 Jul 2015 20:29:29 +0000 (13:29 -0700)]
Bug 14402: Add option --fees to /misc/cronjobs/cleanup_database.pl

This will call C4::Accounts::purge_zero_balance_fees to remove all rows
from accountlines which have 0 balance, and are more than DAYS old.

Test plan:

  Run: t/db_dependent/Accounts.t

If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl
should act as documented, because it is a straight pass-through to
C4::Accounts::purge_zero_balance_fees().

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener <nkeener@washoecounty.us>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14402: Add unit tests for purge_zero_balance_fees()
Barton Chittenden [Sat, 18 Jul 2015 19:58:51 +0000 (12:58 -0700)]
Bug 14402: Add unit tests for purge_zero_balance_fees()

The function C4::Accounts::purge_zero_balance_fees() should delete rows
in accountlines where amountoutstanding is 0 and accountlines.date is
less than the current date minus '$days', i.e a number of days passed
to the function. Tests were added to prove the following:

* accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE.
  The accountlines row should not be deleted. This is merely a sanity check,
  because difference between today's date and the fee date cannot be
  greater than $days.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0
    * accountlines.amountoutstanding is 0, and date is set to $days - 1
      days ago. The accountlines row should not be deleted.
    * accountlines.amountoutstanding is 0, and date is set to $days
      days ago.  the accountlines row should not be deleted, because
      the difference must be *greater* than $days.
    * accountlines.amountoutstanding is 0, and date is set to $days + 1
      days ago. The accountlines row *will* be deleted in this case.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding > 0.
  (3 tests). The accountlines row will never be deleted, because
  amountoutstanding is not 0.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding < 0.
  (3 testes) This tests credits. Again, the accountlines row will never
  be deleted, because amountoutstanding is not 0.

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener <nkeener@washoecounty.us>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14402: Add function purge_zero_balance_fees to C4/Accounts.pm
Barton Chittenden [Sat, 18 Jul 2015 18:41:38 +0000 (11:41 -0700)]
Bug 14402: Add function purge_zero_balance_fees to C4/Accounts.pm

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener <nkeener@washoecounty.us>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 7369: Duplicate item and add dropdown buttons for item actions
Nick Clemens [Sat, 21 Mar 2015 16:27:04 +0000 (12:27 -0400)]
Bug 7369: Duplicate item and add dropdown buttons for item actions

This patch adds a link to duplicate existing items on the edit items screen

To test:
1 - Apply patch
2 - navigate to the edit items screen for a record with existing items
3 - click the duplicate link and ensure item info but not barcode are carried over
4 - save the item and ensure it is added correctly
5 - check that all previous functionality on page works as before

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 15158: Fix t/db_dependent/Circulation/GetTopIssues.t
Julian Maurice [Mon, 9 Nov 2015 13:41:00 +0000 (14:41 +0100)]
Bug 15158: Fix t/db_dependent/Circulation/GetTopIssues.t

create_biblio was returning biblioitemnumber instead of biblionumber.
This can cause problems when biblionumber and biblioitemnumber are not
the same.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
8 years agoBug 14867: userid not generated when defined in BorrowerUnwantedField
Fridolin Somers [Tue, 22 Sep 2015 07:49:39 +0000 (09:49 +0200)]
Bug 14867: userid not generated when defined in BorrowerUnwantedField

When userid is not provided when creating a new patron, it is generated
using surname and firstname.  The bug is when userid is defined in
syspref BorrowerUnwantedField, the input text is missing in patron
creation form. When saving you always get an alert message :
"Username/password already exists". No patron can be created.

This patch corrects by adding this case to userid generation conditions.

Test plan :
- add 'userid' in syspref BorrowerUnwantedField
- try to create a new patron : /cgi-bin/koha/members/memberentry.pl
- there is not input text for userid
- choose non-existing surname and firstname
- click on save
  => Without patch : patron is not created, you see the alert message
     "Username/password already exists"
  => With patch : patron is created, userid is generated with surname
     and firstname
- remove 'userid' in syspref BorrowerUnwantedField and check it can be
  defined in patron creation form

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
  The issue is there, and this patch fixes it.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>