itemtypes.pl - partial revisions, incl. replacement of invalid META Refresh calls

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Dates - remove extra newlines from carps, add partial "00" date tests to Dates.t

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Output.pm - silence unconditional warn.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shelves consolidation to C4::VirtualShelves::Page. I can tell the consolidation

worked b/c the pages still display their previous behavior, including unfixed bugs.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

add three missing packages to Debian list

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a few _() for translator

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

hdl has added a Text::Iconv dependancy yesterday, checking it in installer

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

translation for subtag_registry

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

category entry javascript fix

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Revert "adding TRUNCATES before INSERTS"

This reverts commit 732c11be895b3b2c79942c1071d11f497d87f1dc.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for 1599 getting expiry date prepopulating on member entry

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Labels.pm - BEGIN block VERSION and vars related to export.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

catalogue - exit after redirect in detail.pl and updateitem.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix record->field call on autobarcode

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Populate serialitems table, bugfix

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

nomenclature changes and hide advanced numbering by default

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Escaping the $title in the regexes with \Q and \E to handle nested quantifiers, cheers chris :)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shelves reworking - fix handling of itemtype images, symlink to opac icons.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding TRUNCATES before INSERTS

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shelves - bugfix, toggle "Holds" link, add "Author" column to intranet

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for 1754; fixing I18N BiDi, improvements to handling of language

TODO: clean up the OPAC similarly

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing unclosed TMPL_UNLESS, reported in Bug 1757.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding yuipath variable to help.pl, and doing some cleanup of help templates (standardizing structure, mostly, and correcting some nomenclature).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1686

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Calendar (js) tweaks: histsearch fixed, viewlog template updated

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing unused include

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Cleanup for member entry: XHTML-compliance (close inputs, ids must match labels) and translator-friendliness (can't embed TMPL_IF inside tags); Cleanup of circ and members menus; Menu context flag for readingrec.pl; Correction to Auth.pm (updatecharge -> updatecharges)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changing circ redirect to use borrowernumber instead of cardnumber: If you edited a patron's record to change their cardnumber the redirect would fail because it used the old number.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1400, some variables not being passed to the branch transfers

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

newordersuggestion.tmpl - minor clarification on empty list message

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Suggestions.pm - bugfix need CGI argument to gettemplate

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

VirtualShelves.pm - expanded SQL for shelf contents, fixes bug of no itemtypes displaying.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Circulation.pm - cleanup, clarification of HLT-specific behavior. Please confirm HLT-specific code is still needed and OK.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1624

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Use serialitems table to link to serial in Items.pm

Also update staff client with serialseq and publisheddate for serial items.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a few missing sysprefs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

couple of commas out of place

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for typo, leftover index on 046 updatedb commit.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More replace statements, this time admin/printers.pl

Bug 1546

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing replace from stopwords.pl

More bug 1546

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Whoops fixing the update call, had params round the wrong way

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing replace from admin/roadtype.pl

Bug 1546

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Killing more replace statements, bug 1546

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing replace sql from admin/letter.pl as per bug 1546

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing replace statement from C4::Branch as per bug 1546

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Improving encoding Support for z3950 clients.

Adding encoding for z3950 server information.
Uses Text::Iconv for conversion (ISO6937 and ISO_5428 and ISO5427)
For ISO 5426 (ANSEL or MARC-8) new char_decode5426 based on marc4j tool.

Not Tested on LOC or any USMARC z3950 source. But tested OK on BNF and SUDOC.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding encoding management to z3950

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more logs for MARC::Charset problems

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding generic OPAC translation

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating generic translation POT file

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

renaming translation files to conform to our standard convention. Moving stats.pl and update.pl out of the po/ dir to avoid conflicts with kartouche stats system

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing renewal error messages for todays issues in circulation.tmpl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1740

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Switching debug back off ... whoops

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changing CanBookBeRenewed to pass back the reason a renewal cannot proceed

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

CHANGE TO PREVIOUS .046 DATABASE UPDATE

This commit changes .046 updatedatebase , where itemnumber was changed
to int and keyed on items table.  As there is code in serials module that
uses itemnumber (text) as a list of itemnumbers, this change would cause data
loss if that field had multiple items in it.
Instead, we add a new table to link serial and items tables, so that
(1) we can have many items per serial issue, and
(2) staged upgrades that use the serial.itemnumber (text) list won't be affected.
Further commits will make use of the serialitems linking table.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding redirect parameter to opac-userupdate.pl so that message can be displayed on opac-user.pl when patron submits changes. Copying dialog styles from staff client.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some cleanup of new till reconciliation page, including adding menu item to sidebar menu and adding date format system pref to the script.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changing z3950 search in cataloguing to use the name rather than the host

when listing z3950 servers to search

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1753

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

remove extra warn left in by mistake

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improved instructions for installing DBD::mysql

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

test suite cleanup

Many of the tests were failing or putting warnings
because a valid systempreferences table is
usaully absent by the time 'make test' is run.

Fortunately, only a few modules try to invoke
C4::Context->preference during module initialization,
so added to the test suite override_context_prefs.pm,
which replaces preference() with a sub to return
testing values for three variables: 'dateformat',
'marcflavour', and 'LibraryName'.

Also fixed bug in t/Boolean.t

With this patch and the patch to move the DB-dependent
tests off to the side for the moment, 'make test'
now runs cleanly, at least on Debian.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Makefile.PL - set KOHA_CONF for make test

KOHA_CONF now set to blib/KOHA_CONF_DIR/koha-conf.xml
for the purpose of running the test suite.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

DB-dependent tests moved

Moved test cases that depend on the DBMS and having
an initialized Koha database to a subdirectory
of t so that they will not be swept up into
the default 'make test'.  Goal is to have
these DB-dependent tests runnable either via
a special make target or perhaps from the
web installer.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

t/Date.t - now uses Test::More

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed t/Charset.t

Functions being tested no longer exist

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

C4::Output tests -- removed inccorect tests

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BugFix for Circulation

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding feature : multiple returns via moremember page.

Adding Connection for renewScript
Adding javascript functions to moremeber.tmpl
Adding error management for returns.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Framework update: make cn_itempart visible, rm mandatory on 300$a.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Undo strange copy-paste error from last commit

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

die on db connection failure

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Languages.pm - add a carp for bad arg, return undef upon failure

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

edithelp.pl - cleanup, refactor and error feedback to user

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Output.pm - integrity checks prevent warns, author should judge FIXME's

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

help.pl - bugfix module usage (HTML::Template::Pro)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

borrowers_stats.pl - silence warning

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

help templates and includes - cleanup for XHTML validation, error display

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding translations to OPAC

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

misc/translator/po/hy-Armn-i-staff-prog-v-30000.pot update

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some templating for serials.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Serials updates to link item record to serial table.

This commit makes db changes to subscription, serials tables:
  allow subscriptions larger than 127 issues
  link serial to item uniquely.
MARC Framework:
  Adding MARC tag 942$s (990$s unimarc) to map biblio.serial
Udate biblio.serial on new-subscription.
Use biblio.serial to check if Items.pm should return
  pubdate and enumeration text string from serials table with items.
Update opac-detail so serial items are sorted most recent first.
Adding link from items table to serial table.

Allows sorting of serials in details pages, and removes
enum data from itemnotes field.
Also fixes  visibility in serials item editor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

set of serials fixes to subscriptions

fix zeroes in enddate field and backwards public v nonpublic notes
do not allow modification of free-text subscription history
changing terms from supplier to vendor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

tmpl bugfix - remove '\' in js-generated numberpattern form

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing Carp call from guided_reports.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Still a work in progress, pendingreserves.pl is quite broken

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding link to til reconciliation

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More work on the til reconciliation report

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

stats.screen.pl template file, grabbed from 2.2 needs to be 3.0ified

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Work in progress, working on the til reconciliation report

More patches to come

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1334 better error messages if one or 2 fields are left blank

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding a call to check auth on opac-renew.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Overdues.pm - fix typo ("Context" not "context")

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

another ' missing $query arg to themelanguage()' call

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1741, max reserves not being respected in the opac

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for missing CGI object in call to themelanguage

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1738, opac-reserve now blocks reserving not for loan items

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Z3950.pm - BEGIN block VERSION and vars related to export.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

VirtualShelves.pm - BEGIN block VERSION and vars related to export.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>