]> git.koha-community.org Git - koha.git/commit
Bug 34258: pass an unblessed hash to AddIssue()
authorAndreas Roussos <a.roussos@dataly.gr>
Thu, 13 Jul 2023 16:01:47 +0000 (16:01 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 26 Jul 2023 14:06:05 +0000 (11:06 -0300)
commit54924681d2d6d567e10a248d136a87f02d6f5ca9
tree08a4f86d4bd21ba5bc863aa08e7805f88bd39c11
parent54b8a6433ab1d61a66e04865f15d8674a98a0e4f
Bug 34258: pass an unblessed hash to AddIssue()

In Koha 23.05, we lost the ability to renew an item via SIP2.

The relevant commit is ddc2906b77 from Bug 31735, where the
file C4/SIP/ILS/Transaction/Renew.pm was modified to no longer
pass an unblessed $patron hash to C4::Circulation::AddIssue()

This patch fixes that.

Test plan:

1) Using the SIP emulator, check out an item to a patron, then
   try to renew it. Example commands for a KTD instance:

   $ misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m checkout --patron koha --item 3999900000001
   $ misc/sip_cli_emulator.pl -a localhost -p 6001 -l CPL -su term1 -sp term1 -m renew --patron koha --item 3999900000001

   Notice that the second command will fail!

2) Apply this patch.

3) Repeat the 2nd command -- this time the renewal should work.

4) Run the SIP-related unit tests, they should all pass:

   $ prove t/db_dependent/SIP/
   t/db_dependent/SIP/ILS.t .......... ok
   t/db_dependent/SIP/Message.t ...... ok
   t/db_dependent/SIP/Patron.t ....... ok
   t/db_dependent/SIP/SIPServer.t .... ok
   t/db_dependent/SIP/Transaction.t .. ok

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
C4/SIP/ILS/Transaction/Renew.pm