]> git.koha-community.org Git - koha.git/commit
Bug 28012: Creating numbering pattern: mark mandatory fields required
authorJoonas Kylmälä <joonas.kylmala@iki.fi>
Sat, 3 Sep 2022 11:08:50 +0000 (14:08 +0300)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Wed, 27 Dec 2023 18:06:07 +0000 (19:06 +0100)
commita69b5e6ee99478e730be574178c30f950a09532e
tree5e438226b183554853580b064e2b504a3d1c722f
parent97aab6a98e05ed989e7cc719450d274c80e34bb9
Bug 28012: Creating numbering pattern: mark mandatory fields required

If any of these fields were missing, notably the Numbering formula
then saving the new numbering pattern silently failed, it didn't give
any error but it didn't save any new pattern either.

Note that there is a plan to make description field optional, so even
if it currently is mandatory on the DB level we leave it optional
here (and due to people using production DB's in non-strict mode which
allows this to be optional).

To test:
  1) After applying this patch make sure all the 3 fields must be
  filled in
  /cgi-bin/koha/serials/subscription-numberpatterns.pl?op=new
  page and it cannot be saved without those.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-numberpatterns.tt