Bug 35072: Fix invalid usage of "&" in JavaScript intranet-tmpl script redirects
authorMichał Kula <148193449+mkibp@users.noreply.github.com>
Mon, 23 Oct 2023 13:51:40 +0000 (15:51 +0200)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 24 Oct 2023 13:05:27 +0000 (10:05 -0300)
commitda9f74e56aa3fcaab2a53f0211113d7600263806
treeb19469bc50234a81d84dfdb859788576dc15caef
parenta5fc346403665cf6eb692f401bf1cca5ece3cb81
Bug 35072: Fix invalid usage of "&amp;" in JavaScript intranet-tmpl script redirects

These escapes were invalid in these places, as HTML entity escapes
are meant to be used only inside of HTML elements/attributes, not
inside of JavaScript code.

These URLs would be sent out by the browser as-is, and that'd usually
work on the default install only coincidentally. Unfortunately, on some
setups (such as when using reverse proxies), this would break, and the
URL after "&amp;" would have been truncated.

This small patch adjusts the URLs in templates to not use wrong escapes,
and makes them consistent with how URLs are formatted for JavaScript
redirects in most of the templates already.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/js/cart.js
koha-tmpl/intranet-tmpl/prog/js/catalog.js
koha-tmpl/intranet-tmpl/prog/js/holds.js
koha-tmpl/intranet-tmpl/prog/js/members-menu.js
koha-tmpl/intranet-tmpl/prog/js/pages/results.js