]> git.koha-community.org Git - koha.git/commit
Bug 35078: Remove invalid HTML from OpacShowSavings system preference
authorOwen Leonard <oleonard@myacpl.org>
Tue, 17 Oct 2023 13:51:49 +0000 (13:51 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Thu, 19 Oct 2023 19:00:51 +0000 (16:00 -0300)
commitdc9f6f09d8d6869a41e80a496b58038c246ad6cf
tree5a92e1a1e57d89c24f7b68be3a4c6017d195b059
parent540626ef1510f9cae567efe646bb72f520cfbf2e
Bug 35078: Remove invalid HTML from OpacShowSavings system preference

The options defined for the OpacShowSavings system preference contain
HTML: "on patron's checkout history page (the system preference
<em>opacreadinghistory</em> must be enabled)". This text ends up in an
<option> tag, and even though the form is rendered using the
multiple-select plugin the HTML still won't render and should
be removed.

To test, apply the patch and restart all.

- Go to Administration -> System preferences and search for
  "OpacShowSavings"
- Check the dropdown of options on the preference. The system
  preference names referred to should now be single-quoted instead of
  wrapped in visible <em> tags.
- Confirm that the preference still works correctly.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref