From 0f219a31be615faba830ee69d7328ad8c01642b3 Mon Sep 17 00:00:00 2001
From: Jesse Weaver <pianohacker@gmail.com>
Date: Thu, 18 Jul 2013 09:48:19 -0600
Subject: [PATCH] Followup for bug 10320: minor bugfixes and style improvements

Switch to the new method of showing star ratings. Also, fix some
translation bugs, an error that occurred when caching was disabled and
add a stub unit test.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
---
 C4/External/OverDrive.pm                      |   2 +-
 koha-tmpl/opac-tmpl/ccsr/en/css/opac.css      |  17 ++++++-
 koha-tmpl/opac-tmpl/prog/en/css/opac.css      |   5 ++
 .../prog/en/modules/opac-overdrive-search.tt  |  44 +++++++++++-------
 .../opac-tmpl/prog/en/modules/opac-results.tt |   6 +--
 koha-tmpl/opac-tmpl/prog/images/Star0.gif     | Bin 1360 -> 0 bytes
 koha-tmpl/opac-tmpl/prog/images/Star1.gif     | Bin 1395 -> 0 bytes
 koha-tmpl/opac-tmpl/prog/images/Star2.gif     | Bin 1410 -> 0 bytes
 koha-tmpl/opac-tmpl/prog/images/Star3.gif     | Bin 1391 -> 0 bytes
 koha-tmpl/opac-tmpl/prog/images/Star4.gif     | Bin 1380 -> 0 bytes
 koha-tmpl/opac-tmpl/prog/images/Star5.gif     | Bin 1284 -> 0 bytes
 t/External_Overdrive.t                        |  13 ++++++
 12 files changed, 65 insertions(+), 22 deletions(-)
 delete mode 100644 koha-tmpl/opac-tmpl/prog/images/Star0.gif
 delete mode 100644 koha-tmpl/opac-tmpl/prog/images/Star1.gif
 delete mode 100644 koha-tmpl/opac-tmpl/prog/images/Star2.gif
 delete mode 100644 koha-tmpl/opac-tmpl/prog/images/Star3.gif
 delete mode 100644 koha-tmpl/opac-tmpl/prog/images/Star4.gif
 delete mode 100644 koha-tmpl/opac-tmpl/prog/images/Star5.gif
 create mode 100755 t/External_Overdrive.t

diff --git a/C4/External/OverDrive.pm b/C4/External/OverDrive.pm
index 179ffe2137..9cec867566 100644
--- a/C4/External/OverDrive.pm
+++ b/C4/External/OverDrive.pm
@@ -122,7 +122,7 @@ sub GetOverDriveToken {
     $token = $contents->{'token_type'} . ' ' . $contents->{'access_token'};
 
     # Fudge factor to prevent spurious failures
-    $cache->set_in_cache( 'overdrive_token', $token, $contents->{'expires_in'} - 5 );
+    $cache and $cache->set_in_cache( 'overdrive_token', $token, $contents->{'expires_in'} - 5 );
 
     return $token;
 }
diff --git a/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css b/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css
index d8c289c624..0901d6b883 100644
--- a/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css
+++ b/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css
@@ -2842,6 +2842,7 @@ a.reviewlink,a.reviewlink:visited {
 .branch-info-tooltip {
     display: none;
 }
+
 .sorting_asc {
     padding-right: 19px;
     background: url("../../images/asc.gif") no-repeat scroll right center #EEEEEE;
@@ -2860,4 +2861,18 @@ a.reviewlink,a.reviewlink:visited {
 .nosort.sorting {
     padding-right: 19px;
     background: #EEEEEE none;
-}
\ No newline at end of file
+}
+
+#overdrive-results {
+    font-weight: bold;
+    padding-left: 1em;
+}
+
+.throbber {
+    vertical-align: middle;
+}
+
+#overdrive-results-list .star-rating-control {
+    display: block;
+    overflow: auto;
+}
diff --git a/koha-tmpl/opac-tmpl/prog/en/css/opac.css b/koha-tmpl/opac-tmpl/prog/en/css/opac.css
index be2141aaaf..99a2d45992 100644
--- a/koha-tmpl/opac-tmpl/prog/en/css/opac.css
+++ b/koha-tmpl/opac-tmpl/prog/en/css/opac.css
@@ -3058,3 +3058,8 @@ padding: 0.1em 0;
 .throbber {
     vertical-align: middle;
 }
+
+#overdrive-results-list .star-rating-control {
+    display: block;
+    overflow: auto;
+}
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-overdrive-search.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-overdrive-search.tt
index 4ba9f8d15e..086a22bbd8 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-overdrive-search.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-overdrive-search.tt
@@ -2,6 +2,8 @@
 [% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog &rsaquo; OverDrive search for '[% q | html %]'
 [% INCLUDE 'doc-head-close.inc' %]
 <script type="text/javascript" src="[% themelang %]/js/overdrive.js"></script>
+<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.rating.js"></script>
+<link rel="stylesheet" type="text/css" href="[% themelang %]/css/jquery.rating.css" />
 <script type="text/javascript">
 var querystring = "[% q |replace( "'", "\'" ) |replace( '\n', '\\n' ) |replace( '\r', '\\r' ) |html %]";
 var results_per_page = [% OPACnumSearchResults %];
@@ -9,7 +11,7 @@ var results_per_page = [% OPACnumSearchResults %];
 function fetch_availability( prod, $tr ) {
     var $availability_summary = $( '<span class="results_summary"></span>' );
     $tr.find( '.info' ).append( $availability_summary );
-    $availability_summary.html( '<span class="label">Availability: </span> Loading...' );
+    $availability_summary.html( '<span class="label">' + _("Availability:") + ' </span> ' + _("Loading...") );
 
     KOHA.OverDrive.Get(
         prod.links.availability.href,
@@ -17,34 +19,34 @@ function fetch_availability( prod, $tr ) {
         function ( data ) {
             if ( data.error ) return;
 
-            $availability_summary.html( '<span class="label">Copies available: </span><span class="available"><strong>' +  data.copiesAvailable + '</strong> out of ' + data.copiesOwned + '</span>' );
+            $availability_summary.html( '<span class="label">' + _("Copies available:") + ' </span><span class="available"><strong>' +  data.copiesAvailable + '</strong> ' + _("out of") + ' ' + data.copiesOwned + '</span>' );
 
             if ( data.numberOfHolds ) {
-                $availability_summary.find( '.available' ).append( ', waiting holds: <strong>' + data.numberOfHolds + '</strong>' );
+                $availability_summary.find( '.available' ).append( ', ' + _("waiting holds:") + ' <strong>' + data.numberOfHolds + '</strong>' );
             }
 
-            $tr.find( '.info' ).append( '<span class="results_summary actions"><span class="label">Actions: </span><a href="http://' + prod.contentDetails[0].href + '" ' + ( data.copiesAvailable ? ' class="addtocart">Check out' : ' class="hold">Place hold' ) + '</a></span>' );
+            $tr.find( '.info' ).append( '<span class="results_summary actions"><span class="label">' + _("Actions:") + ' </span><a href="http://' + prod.contentDetails[0].href + '" ' + ( data.copiesAvailable ? ( ' class="addtocart">' + _("Check out") ) : ( ' class="hold">' + _("Place hold") ) ) + '</a></span>' );
         }
     );
 }
 
 function search( offset ) {
-    $( '#overdrive-status' ).html( 'Searching OverDrive... <img class="throbber" src="/opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif" /></span>' );
+    $( '#overdrive-status' ).html( _("Searching OverDrive...") + ' <img class="throbber" src="/opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif" /></span>' );
 
     KOHA.OverDrive.Search( "[% OverDriveLibraryID %]", querystring, results_per_page, offset, function( data ) {
         if ( data.error ) {
-            $( '#overdrive-status' ).html( '<strong class="unavailable">Error searching OverDrive collection.</strong>' );
+            $( '#overdrive-status' ).html( '<strong class="unavailable">' + _("Error searching OverDrive collection.") + '</strong>' );
             return;
         }
 
         if ( !data.totalItems ) {
-            $( '#overdrive-status' ).html( '<strong>No results found in the library\'s OverDrive collection.</strong>' );
+            $( '#overdrive-status' ).html( '<strong>' + _("No results found in the library's OverDrive collection.") + '</strong>' );
             return;
         }
 
-        $( '#results tbody' ).empty();
+        $( '#overdrive-results-list tbody' ).empty();
 
-        $( '#overdrive-status' ).html( '<strong>Found ' + data.totalItems + ' results in the library\'s OverDrive collection.</strong>' );
+        $( '#overdrive-status' ).html( '<strong>' + _("Found") + ' ' + data.totalItems + ' ' + _("results in the library's OverDrive collection.") + '</strong>' );
 
         for ( var i = 0; data.products[i]; i++ ) {
             var prod = data.products[i];
@@ -56,9 +58,15 @@ function search( offset ) {
             results.push( prod.title );
             if ( prod.subtitle ) results.push( ', ', prod.subtitle );
             results.push( '</a>' );
-            results.push( '<p>by ', prod.primaryCreator.name, '</p>' );
-            results.push( '<span class="results_summary"><span class="label">Type: </span>', prod.mediaType, '</span>' );
-            if ( prod.starRating ) results.push( '<span class="results_summary"><span class="label">Average rating: <img src="[% themelang %]/../images/Star', Math.round( parseInt( prod.starRating )), '.gif" title="" style="max-height: 15px; vertical-align: bottom"/></span>' );
+            results.push( '<p>' + _("by") + ' ', prod.primaryCreator.name, '</p>' );
+            if ( prod.starRating ) {
+                results.push( '<span class="results_summary ratings">' );
+                for ( var rating = 1; rating <= 5; rating++ ) {
+                    results.push( '<input class="star" type="radio" name="rating-' + i + '" value="' + rating + '"' + ( rating == Math.round( prod.starRating ) ? ' checked="checked"' : '' ) + ' disabled="disabled" />' );
+                }
+                results.push( '</span>' );
+            }
+            results.push( '<span class="results_summary"><span class="label">' + _("Type:") + ' </span>', prod.mediaType, '</span>' );
             results.push( '</td>' );
 
             results.push( '<td>' );
@@ -71,19 +79,19 @@ function search( offset ) {
 
             results.push( '</tr>' );
             var $tr = $( results.join( '' ));
-            $( '#results tbody' ).append( $tr );
+            $( '#overdrive-results-list tbody' ).append( $tr );
 
             fetch_availability( prod, $tr );
         }
 
-        $( '#results tr:odd' ).addClass( 'highlight' );
+        $( '#overdrive-results-list tr:odd' ).addClass( 'highlight' );
 
         var pages = [];
         var cur_page = offset / results_per_page;
         var max_page = Math.floor( data.totalItems / results_per_page );
 
         if ( cur_page != 0 ) {
-            pages.push( '<a class="nav" href="#" data-offset="' + (offset - results_per_page) + '">&lt;&lt; Previous</a>' );
+            pages.push( '<a class="nav" href="#" data-offset="' + (offset - results_per_page) + '">&lt;&lt; ' + _("Previous") + '</a>' );
         }
 
         for ( var page = Math.max( 0, cur_page - 9 ); page <= Math.min( max_page, cur_page + 9 ); page++ ) {
@@ -95,10 +103,12 @@ function search( offset ) {
         }
 
         if ( cur_page < max_page ) {
-            pages.push( ' <a class="nav" href="#" data-offset="' + (offset + results_per_page) + '">Next >></a>' );
+            pages.push( ' <a class="nav" href="#" data-offset="' + (offset + results_per_page) + '">' + _("Next") + ' >></a>' );
         }
 
         if ( pages.length > 1 ) $( '#top-pages, #bottom-pages' ).find( '.pages' ).html( pages.join( '' ) );
+
+        $( '#overdrive-results-list input.star' ).rating();
     } );
 }
 
@@ -140,7 +150,7 @@ $( document ).ready( function() {
             <div class="pages">
             </div>
         </div>
-        <table id="results">
+        <table id="overdrive-results-list">
             <tbody>
             </tbody>
         </table>
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
index 551a5151ba..9235b2b8ac 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
@@ -267,18 +267,18 @@ $(document).ready(function(){
         $("#highlight_toggle_off").show().click(function() {highlightOff();});
     [% END %]
     [% IF ( OverDriveEnabled ) %]
-        var $overdrive_results = $( '<span id="overdrive-results">Searching OverDrive... <img class="throbber" src="/opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif" /></span>' );
+        var $overdrive_results = $( '<span id="overdrive-results">' + _( 'Searching OverDrive...' ) + ' <img class="throbber" src="/opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif" /></span>' );
         $( '#breadcrumbs p' ).eq(0)
             .append( ' ' )
             .append( $overdrive_results );
         KOHA.OverDrive.Search( "[% OverDriveLibraryID %]", querystring, 1, 0, function( data ) {
             if ( data.error ) {
-                $overdrive_results.html( 'Error searching OverDrive collection' );
+                $overdrive_results.html( _( 'Error searching OverDrive collection' ) );
                 return;
             }
 
             if ( data.totalItems ) {
-                $overdrive_results.html( 'Found <a href="/cgi-bin/koha/opac-overdrive-search.pl?q=' + escape( querystring ) + '">' + data.totalItems + ' results</a> in OverDrive collection' );
+                $overdrive_results.html( _( 'Found' ) + ' <a href="/cgi-bin/koha/opac-overdrive-search.pl?q=' + escape( querystring ) + '">' + data.totalItems + ' ' + _( 'results' ) + '</a> ' + _( 'in OverDrive collection' ) );
             } else {
                 $overdrive_results.remove();
             }
diff --git a/koha-tmpl/opac-tmpl/prog/images/Star0.gif b/koha-tmpl/opac-tmpl/prog/images/Star0.gif
deleted file mode 100644
index 44ffdf488560eebbf1f8a5db485fabe581db9625..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1360
zcmW+#dr*{B6u&wqk14g)nX*VzN^ONQZ;1<v3Wdm&qN$aMgR)!!6D$>5lbw+Tc?E;3
zLD#52O_$V^9*)WkqwO@QbD?!KQy%MEWCe@R)@7yB@9zEY%sJ=xI^Q>UUcz+KN;4b9
zyo`~4ibxU(B2L6~r4%ViN|55Dm~Ki%Qj!!TIZ38xg(4wI2ojtG)2mz&m&65ePMiUW
zm?9>L31XZW3Sa{oSXjn1(>(e~rG!#kDW+*rNvWhzk}Juy3N(dOLMXwNU|JMrxl~*z
z&J}0Sh*ia;VnQ*l7+9eiU=R(JkcA$IfemP2VVP+|y2cYyaw(bi2U=7@NWrCG+AdU}
z$%W)xat8Mhg;~jjWLz@XLmrTcZNvfp5CMl!4KRp?N{m7Wh=C1gU@@JXZllKILNFa9
z{DBq~=Ylij3cFB&reIt!<cOpZ0CZs-LBlPgL>`cdZNvdhFbs!K4KRqtCS*Yeh=C1g
zrcb1&(MFBOa4`f4f1pLhnf^F*u7P{&X5fT6=D=0-Y#?ZzdLTQ!8i+$5A>dFW1w`wc
z1axTN05m=aTnXX9Q-G?8=x3tui4GARAo`kUD^Vd)5m6~o1(BVoYTywLyPIe~Q9aQ?
zqQgW#5H%7xANjTp__q!8mkjtT{9e2N-vZx1h5iQ>5ARvMp3V1ftnqbz)ay3iYhKcI
zYM$qK!i|F_eEQ>jLk7Vpi+~2E{|Och(;;DrM`};mf=3#cpFUFOEE*A>RFl~2exuCL
zo6`RD!WE{HF>|cl(+#T<i@itJI`2%ml~nw2@$L9}dwP8Jw9!>*MTgAJuV#)L{Gfiv
z#B+u5V_VN(9M*QcCZu{=o@dI~clIYgne?k?-Q+(Cymu@Ywne5y<=(!2u5o`u>ZOMC
z-}j}oRi(y$`rz#L*UOf!jm;Z+#Z%r^ot@fX^R=XZknE2BuxEVEvlHjfKDx18g{+(F
zdewYpXJpz%WvT5v-813crW(uo&fgqM%Cb|IUCneInA>Q5?rNCn?6s45{;KS#oGT{_
zM@D6DPWkJ~_59(ltZ4N0-8?Vbaw}$>_}CM4tDe?)W0oJwasRaOfZMXg*VpxD_^1We
z8q0mp<u7w{##;aLJ?ePs8|%K6&hky}Ezahc&@*Yz=Z8-HqS6*LwEAlP6R{a93q~&u
zZYea3-#I+GJF&BzbzIo!Dt<9^)2h<YYw^2FCJn9{QTEy|pWOKD<=u`|sjV6DEvEKM
zt6SbmeavLuel4uNa!H&a^96fw$DX}A-(F;?{CwfmF7x8MM|L!uI@Z}*s+Sd-gj}7K
zSvfPyo;hJx(5aX9)vPs|J9n)=@xE)u<qdtqV*8JU&yTVihB#^qo+)+2l{M{IP**e|
zI(cvT($LIW+oJxAxW6Aya>e@IGbTHX_AJk=y4Fb}W_@dnEburQ@{OL^-x+Ua%^A2;
lntV8<$5uJ3Y0Qv_xJJW<h&R==yWKy!5+)ytA2f)?{0}p#!-fC=

diff --git a/koha-tmpl/opac-tmpl/prog/images/Star1.gif b/koha-tmpl/opac-tmpl/prog/images/Star1.gif
deleted file mode 100644
index 203863874dcba824ea7b948e0ef00c750cefce19..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1395
zcmW+#dr*{B6u*citjX$%PLY!4Bo5PL<1G|vVb<}1Ha;3lY6caOxr&(OqfB<N;icjx
zuIQMz40I_(WsO8p2{Q-NY_6*bga)Xv$ZHLTz(HK`^t*fiJ9EzYz0UW|n?H9(WMUEv
zX8nwjeu_vE2_jC!bfpw2NlK97q?m3>MN*O!Bsoc@XN4jmNeB|01k<Zr5tqaTaZa28
ziI^fLi3wty7z$tm8dzAyG}Ao#Nu`8RTq&k$QAw$!P?9Ujv<ftZR6;1hm0(&FX1P>c
zD9#mU(1=yVq+&ubt{7OM8ek9&m5_xVh=C1gU}2eQL%PNjQgSJo_6J&2LP)`-VA?KJ
zpvi^gTyh5Y5QSOEgk)SY*h3zWiEYFI{}2I(Pz^AMhDwY=2Z(_UXkam&oNlAW<3cbU
zB>aIE73YF8<O;h`fu>+wFyx4&5dd^y96`e^qC_5$iEYFIO)w0HPz^AM#wKJz2Z(_U
zXr@o3r_n}@$8a$O34fqP#hLy%bgsU8>!$C7I%eNh^sFyvow_eOz3PiYAHnBPBl$$@
zoA`8SU>`I-2V4o^!IO{bB+&_?bfRpcT|~J=c|->WpW>4FM1@4fL{6epL}!R9iK?Cs
zY<oJ8G3ebs_#|i0o9pf0`=mG9`zZHu*S7x7)IN90K--4iyB~Y5zTNFw&{G}fIsdBX
z;+%$~VJ)X4>JEk8*f|QH{=|WyelW^jhX$tq2^Ij;f#YIJ4`0d*7#$w}N9mEO9U~_#
zI260rQJK>_dBy&7qa0?dsWE+c<TOWYo~gUhe_%;y<i_zYyR7q#j&~16th|!6#`sF~
zfuKv@N5xHRzv&o}ZOSeV?wDom?`*2RdL!|jb?vU*_0k@?%o#sw#r2BX&bm{Em|4G{
z-54IT%^UQmHO!P!{#o1QGuE)Ft1PKK_tVR4aotg=k6&;(ZC&f{UPv2LJ-*@Gn@Jb_
z>;A5<{LgJpd%wxFIj(D5MRiN%=c5x&#z$-zQnUMww2<YUwa%5pW2e`@wYIiodDQ{4
z{q(2xzil#34LGx6wROPJRv2=2LI-pIdaSkFX)V9~{7<Xt-rcnNEzM;=r*vOwjQY~^
zpl08eJ^2Z}du|=IMYji?_+ouSa^}Jrk9M~fOlRvSO-K)Tw8Qn4U(kmM8-`6jcR$O&
zr)uoxTOCW6XSO9(<!7`y3++)8bBh<|gcZFw!4`OAO0(_G!D4&#<CgwqF^0dmD{`!1
zWRMtky?2$psixY!*UvEj2TSyjJ1urYPhp<<@SLm0J%QIUM?~EFdf$kQ=9-$?ZxVB_
zEtH0>fkg+CzRj_Jmwe@;2j+F}Jr@%5Y)bIr<kp>|7e%;B<;{Y&p)=PU*%+Et?8piU
zAA2}s?mxvAZ-akb^k83^vA}R))uI_5wRG{!#;i@r7DryiOUI9IUovy;v7<#5;TGpD
zgU9LruRF!^tWS=N`q7kSG*=pCm*n|(WR}djY}&f+6wOX~ST<(j<r2%2Df@3*K6vf)
aCzi%twk7B96rJd*cv$W^`HP<)i~1ik=F+49

diff --git a/koha-tmpl/opac-tmpl/prog/images/Star2.gif b/koha-tmpl/opac-tmpl/prog/images/Star2.gif
deleted file mode 100644
index 2b60940ffc660d254c308ebf1df7e94c59c0f600..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1410
zcmW+#drZ|;96wCRdzpfUOty@vOmX;N?c}%$VS<X<NJ}Qek;2U5Yo^4b0cvBHhnnI8
z9~}bnF-asqB{wK28U!wnz(OSzNG^K0B64#VMbPfI&$;Kn@4nyf=k@*lqE@XiElT{H
zO<^O9k$#Fu5(y$s#B`+;DM?C@;-r{vN<~tV6eKxGre}pBAxQ`loCMRWToISV1#wQC
z0g0F*CW#4RoEQpV0~%OZ#x&DB`bnjPQd}vfX;De3q)?J8$+QYIg;YW)!IfZI6lS?p
zTqw>JXV8dM#iU|FF|HU`p&DQi4V93E9*BVrXkcNPX+yfk6H;<1nf3=-R6<C>rC{1F
zRG`U)<XmzF_Yj3y$%JHFGT1{Nkcn-?0sjyIhfobLh=xjxLI;R}4QOC7ot$o?#^XXT
z9VGmL78U1$Gvo@pP=TgkTrlK_q!9pgVH`ojEuusokcn-?0ZlLrhfobLh{h&lK?jI|
z4QQrMq^HqFjmK~?1POnjMa7x^ICQSAd+Vm_ggR!|RrIVYXq~z%JH6_PLm$EAP$RiS
z>zlZAXkZsKJ_lS0;lY!Os*)(n>C7ePA#&yuo%rt!ZdgKef#@<(1yMCo9Z}<((X7`a
z$H#_qUcbm6d7A0y+cDao^r9!het(nwcC_Q~xF^kv9UUu%T36Yd=RR*=KTtD$uqn#^
z=UU6P`CX;6t=CNhb;~-7{M!yp#-~4H)ZGn6**s`q`k!D1m^MyZdFAZyW`j>q{EaK;
z8uKOvtS(x4)zXyeb7#v*zhM8Uqm$dx3+9}7bmM@-nzi@aFSj(NTAHq!FD)o-&Rh6L
zcZ#34f7qD`na*t6k!iIBUf=l7+A(E&dwRJ2S)b9jBqne0%Bg^<Ux>)m4Yfn@hP0hE
zSI37on}dQkez1SkGBf7p-TCpgZ`~{Vs6V>AX7{6pq{x=m;-#s!Wn&)m{E8PJ_Lw|(
z!AQuz4_iF?>dl>%)nOUKmfl}lc5e#b=e{uc<%A9IZ|}G?zT};#%A#FK-8DwPkOk9B
zZdOBU<-X97p`PE&H%oVYcP**s*Q~AkJBRqTjF;EW<QEtIoZ5cx*)9q(g*Mo`9{f}`
zHLyNm)Y0`<)$ZWEMd@y~J3BX5g*ocdI&%VjzjC@6Hl~f6nUcT0JEb~0<6eRz`s<<h
zY}2#f{&Y@Jj`t3q-fZKuaYs{opGTfuI`hP(?t?=~zTfBF&%SUZqQAzFc$m+Q*=!0H
z=DvuL+vd;GUJrJ7AB)J1eRSMd;p4UFT@la_a%@IZYr!WU$30#e8(}<m+VgR8Ti9?{
z@|yS+xr>C{YAp~EaftyRntDx!{8&TQtia+lOZu^r<h!-EiW4pCyu&X(Ust#!$G^~a
z-m@(7f$8Di$iQ>PRja)&o*uLICl;*Fc=ChCV{=>hn5|>YlCi<YZ4ssCH(d@YuMEm=
zHT|=#IzQC9$1$<Yy}R(~;-|x7<rOsp8-A>6@H#ng&{=n=z1m}W`Pz)!i7DQpw>(ew
uoPM<@v!c>H=Rw7CpF8IE7~^&Gq$QrUnUm^lcX!(BUs=nmmb<yJ(EkB}4Az1G

diff --git a/koha-tmpl/opac-tmpl/prog/images/Star3.gif b/koha-tmpl/opac-tmpl/prog/images/Star3.gif
deleted file mode 100644
index 3ff6739cd12809662b6a09abdd29d70b839197d8..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1391
zcmW+#ZBUg(6kY=nEF32cK|n?2V=(!%2`F4ZP=O}I8Fk2sB0v@ikWxs+A_p8&Qogcu
z^MaBJgh4Q3e5ehEnlXC;gGp|R4%|R7#0wWfFx{TL`|r#-=lMGC8y2zAZ%y0|vVcqx
zBGnU8aw(aVR7#>MA*A3^Fe#`ML^ZjPoJ-Cmr;-yj%Y<ZHGA0?7jHp#AB;}GaNvWg+
zNRkLixFk#xDhUc;0~%OZ#xzkp>Tw~M5L5`FXi;%4I1`)-PLv8X85fKRMg=2E6lN(G
zlnF`&CD4dfLAW4H5Gn{*p&DQi4V93E9*BVrXkcNPC_}2oW1LgYiSh?pRE%*(IU~w0
zRG>*2r<79y_Yj3yP8cVY6WBu@kcn-?0sjyIhfobLh=xjxLI;R}4QOBym7Hp$#-of8
z6(szD78Rw8666ZIP=O{Rlo8~Jq!9pgVH`ojEuusokcn-?0ZlLrhfobLh{h&lK?jI|
z4QQfHq^8kEjYn`X1POnjMMa7FI8?6Yd#k4Tgeqq9Rn)9GXqCD-JGE+#Lmk2FP$8K`
ztDBg0C}1-*J_lS0;lUHAUcNXaUmlgRM9MNL&q`S><xf&JNqO!0RLP7fcXBZ0+3>!}
z`yW2-i8S?YH@16^>3oKN^EY*Ge4>jOZSx%db@iBt80*|Na&`G&%UdHi)<3-!HGFBw
zgIX^`!>Y$uH{3n%_IJI{&?Wyn+QnV@cH-cx`1D<;EoZ?fc@r9l`X`7rOxrkz*PXeR
zYi;KhbE~er?aTSg-`0lL53J9$`#te^)x3o31<sm~*F1ukMI0IFZT{-y?!nN^Rjwtb
zp-4j;U+r4$zqjLjTd5{<d_upu)%Rn!C5tx9l(=;6AJ1N^nX~P2ca?2Yj>R3FduUC}
z)ny~rrh6?JMq}UQr1aFV%B1evw3MP$ebYz!KitAMIY*?&G=6UQHqyEI6RYPhZ3CK&
z{W*_C>B_MEE-jyqKDyo37!@0sQ|uA_i+2B>hn*IoTfCDTFS3p@n>>pvZ)knf^hdM)
zxfyxTPv6jZzvD&P-lq@F=;}A^ZGQhs)}--9-jDyKnjYS+^oY%NY02nmwV059<~g03
z-t|hIqjuE?WIA=IzC1d;%jNR!N8Smtper!@#r@>yqA#Y`EL^&8w$7^KfHBUX^O>lb
z<B&U~aVTFmesb_$wsm|}T!6FJ@&2_=S$E=cViLR0e73Om#6W&u!_KY%qr<y}0nd#W
z=O6PKs7eSKHy$o6oLk(j^Y!}9qt)lI+m00_w%+;`Ayajx0)La(6Qx<>wRP~D?Ys1e
zA+hm4xSa@EcIa!;myzq_yJc|$JC%Mjxl1$Any@HPJ84KPJMiyxWtn!Yx$v~j5rfV*
zH?7;<H{S7_=h=IH?eCqNtq<)CoX%*E3Y=M*UsR#Znp<5pr}(erz|(ovMSc&0-|_44
z>)m<Lw!-q7*UFlo2i6v8O6_|JgXYe<+h2FX%71gvEqBXUt?{VgLU8Bn3!XICM`nB<
feBFKPypU&}6HnIlvy{>1M->-FTkL0B694}JB*n>K

diff --git a/koha-tmpl/opac-tmpl/prog/images/Star4.gif b/koha-tmpl/opac-tmpl/prog/images/Star4.gif
deleted file mode 100644
index 473cb32087da78d40ebd8968a542b0bc50b76c55..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1380
zcmW+#dr*{B6u;;yU^Oz@IOQ-9g-8-ibsKQoz!7PYkjJPLBacyos}4kg;ZpWcUW$!^
zNyH@u9Yeqwlu|-eQrbYl%fnD?f<%Eua9bX+kdbox-M#;vIp_Rd=lg;~^eeSn63DaU
zA3~&hLP{<rlafkFR3(HITnZ)ym4c`y7m{<yndDS*qGp+pj7!EOqmmJ|N`<6cQYI;t
zlmJN*Aqkg+NkSz-0c=163(J@$ibp*z1QUV^K@=@2&IM<JQ^AQ+fhOaEF~O){M2W&I
z<$^Lnsh|WJu__1`gb6|g0V`Ak45FbDvd{xDumKG$EE8o&)p(3^$~jT~K#Pho&M0R@
z*@X%;DdUuKO5h%%Fv|(!gmMCV$OAI5jX2;RBH$3J0S3`fiBaePF|Yv*ETWQAZPa*_
zF`|NmKhUD0lu?3QVHYaUWP~z;9Fa5vfG&(9Xt+g`$OAI5jX0nQhT#yZ0S3|7ge>R)
zF|Ywm)QQwI+NkjeE`}iC545N#Q6GoO)pl>yw4G4JY`cn@wFRwGw`HeRZE>h0*c>V(
zn`m_tn+^qRgU088D<M31vQbq_d1dx-&g|oYM<eM|cejjotsC!tck=g5V=X=tZN4Kd
z{*zsLOIygO(Q~9pJ0U_QI-<;%mJMEhW8k9B+!Qo)b<J37#7M1c-x;rgbM#@o?{LE^
z%P*llr#yygb>;?r-|5#)XSBoT0`44j?fh!7*z*)VeYbx#b}&j_fd-=f3E}|Lj?Qaq
zjyGmGEM5_Nz2<~*pVLe499{cE|F5Zw8^Z=YQk|RkyXd~ij!qdgelW+q$jji<-&(Zr
zT0^!&ipg((Z_Sp0N8`PIADLg6(X6m;>nzs0Ex2CfU2fcIy1F;XQ0TU?YGaxH*rxRR
zb=8(ut!Vl9L16xSEqS5A5%HHZ9B%5PZghLcX1QD|kL#JX#AV+5xm6Qf=dCkXo=)q^
zT@>S+96B$#tGPO+G4<}%^qzG-N9%WvJ-mNud56ntQKH>F-@D}e$lgjngZZ)6I{cfa
zA+adzyD7^R`IDB-WW>CGY>sBTS4MkJa%yQ?RhIoi*Oa05+xoKjCvP?mb<}N;b+aX#
z>;LL(3vnImK0Zzg4n}mJdgkx6tjJ3_lcJ&2Fk~9O=9)hHjs5XG=Ee=1W9>%2y_ae4
zc&9Mcdb=Vv(Cl=|#qj94?UA{I$tz3u&D-m_HQjwtP=2oCuF6i|rl{z?&mC)zglA6n
z8ao1g`zucdnyuI44(U9shYD_)Jo5t++A6}*-g0w~&<<yJh3mSW6n7Rz#q-3&>(}pC
zRy4jnFETpr>rWyM%r$9vc(bFEY4ybABkekCZ`Q(q|Ewn?j~RyQx0QYQM_xtgXEWT%
zKX*av@?!hLInHT2mu`GeGCgk0_n+}R&{;m6aB)XP&eqc}SCqQAcj%ISG`3e(EnS`9
zmiXtZ9uLY+EV-4x>cXcNlFn+TCX)g`tX~ruV0<yCEOBnRF|2&a+c!MUIzGSK>HGPw
WB{>D$+-0`Z-OKe#Id5l2bpHd;>%uJn

diff --git a/koha-tmpl/opac-tmpl/prog/images/Star5.gif b/koha-tmpl/opac-tmpl/prog/images/Star5.gif
deleted file mode 100644
index 0a61173924a33b422e21e9d649b9f50b36321465..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 1284
zcmW+#eN2^A7(XnUkaYoX)3$;I<h^-iOgZw^MG$CL(TO!nC2*w3`6B}=`H0dsG(l!v
zFe^Bb2tv-9GLR1=qy{$}$uXKjph$)RdoLFTbOpqZPQP={f6t!h`F%a_yD`BM5xHj{
zd6p~?BGnU8aw(aVR7#>MA*A3^Fe#`ML^ZjPoJ-Cmr;-yj%Y<ZHGA0?7jHp#AB;}Ga
zNvWg+NRkLixFk#xDhUc;0~%OZ#xzkp>Tw~M5L5`FXi;%4I1`)-PLv8X85fKRMg=2E
z6lN(GlnF`&CD4dfLAW4H5Gn{*p&DQi4V93E9*BVrXkcNPC_}2oW1LgYiSh?pRE%*(
zIU~w0RG>*2r<79y_Yj3yP8cVY6WBu@kcn-?0sjyIhfobLh=xjxLI;R}4QOBym7Hp$
z#-of86(szD78Rw8666ZIP=O{Rlo8~Jq!9pgVH`ojEuusokcn-?0ZlLrhfobLh{h&l
zK?jI|4QQfHq^8kEjYn`X1POnjMMa7FI8?5#d#k4Fgeqp&Rn)92XqCDvJGJVHLmk28
zP$9WQtDCrVC}0;fJ_lS0;lUHA=10<|`?fl7CC?3~&h!M&UJKK@Ua|ic<-B2;x|Z;7
z-%jVBNmHGM=_@9OZQZO$nC*RYvORG0^18{cSEsLTn`rT~HwN6PGmSI`Pqc<<?J-lG
zTW;09bo-oPq9y2`hS2e5v!mTIRu`!?Mh{f@4%e7^kNM!!_g{2(gHaL$4MhDD!~>>1
zU)WS%)p5i_Z%XN|ueKF=2X6j$Q^T3A<Im|od1!b)ZKKs^eWAPO+LVYapRH$t@<Y<M
ze7)NDBYk+H@2@;G>w43ow{aUce_VJYEOWT`=wF4)*Z;6))$27OU&Uo;+4j!Q6FYL^
zjb472^E?`K{a5=}4<6aud}8WB=;WpI$u}!Q%X2Rz{dBV_V`!;0Ir6~d_?RuP#IGYO
ze<9QHFns3k&LX{YZt1Qydu&hmI8NOj3>g()tk|A=u(j&ayMs*+R+iPBYCCw^vodiw
zBgZk&u;lk0yRFUp2g}oI#;2aodvDmbf8pn69=&}%qh+YMqAWQ#LhJc%drYQp+qAtu
zCv~JmSK0RA^o1Vd8{xW?`GIlIi+QP0sgDYrcZPPB|MK6Vg2!tYPH%7=bMB71KhyYH
z!4kudRRwncb5(IqTeKICdT%yX$IX0tz#8c|pH^aC5zseM<Zs<|H`aLg<$z-SH(K>^
z)0OVKpRMZb_BU(wfnL#zqm3mo=K1?+rSZ${fu(WFxOY@kaB=NPgC&38$*0<Fy6Cw-
z;=N)XYw=^TZ+&22S-zLGrkAA_MxKpLzgRq8@nl#2*@~pxq|%t|W%sO=?z7yOci3>x
dSba#BtyLDYQLU!bVzSqMx#OMhH@LYG^Z&S!h!y|<

diff --git a/t/External_Overdrive.t b/t/External_Overdrive.t
new file mode 100755
index 0000000000..a6598466f4
--- /dev/null
+++ b/t/External_Overdrive.t
@@ -0,0 +1,13 @@
+#!/usr/bin/perl
+#
+# This Koha test module is a stub!
+# Add more tests here!!!
+
+use strict;
+use warnings;
+
+use Test::More tests => 1;
+
+BEGIN {
+        use_ok('C4::External::OverDrive');
+}
-- 
2.39.2