From 285795d76923770937970a702c13727be6e31c1a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Marc=20V=C3=A9ron?= Date: Sat, 20 Sep 2014 21:38:02 +0200 Subject: [PATCH] Bug 12974 - Argument "" isn't numeric in numeric gt (>) in opac-results.tt If an item has no star ratings you get an error message in opac-error.log: Argument "" isn't numeric in numeric gt (>) at (...) /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 467. To test: In OPAC, search for a bilio that has no star ratings. Check opac-error.log for message as above Apply patch Repeat search Check opac-error.log again, there should be no more warnings (Fixed mistake with brackets, see comment #2) Signed-off-by: Magnus Enger Works as advertized. Looks like you have to be logged in to trigger the error. Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi Works as advertised, passses xt/author/valid-templates.t --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt index b3334586a1..72a3a898cc 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt @@ -460,7 +460,7 @@ - [% IF ( SEARCH_RESULT.rating_total ) > 0 %] + [% IF SEARCH_RESULT.rating_total && SEARCH_RESULT.rating_total > 0 %]   ([% SEARCH_RESULT.rating_total %] votes) [% ELSE %]
-- 2.39.5