From 3c9cb0ffd3c9230d051e22c81f47fca8de054648 Mon Sep 17 00:00:00 2001 From: Alex Buckley Date: Mon, 27 Mar 2023 03:17:16 +0000 Subject: [PATCH] Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages If a basket group contains many ordered items then this patchset will ensure: - The page number at the bottom of the first page is not obscured - The table of ordered items does not start half way down the second page Test plan: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add many orders to this basket, for example 25 items (this is to make the Order PDF cover multiple pages). 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm the PDF is multiple pages long. If it is not then re-open the basketgroup and add more orders to the basket and repeat steps 5, 6, 7 and 8 9) If the PDF is multiple pages long then confirm: - The page numbers at the bottom of the first page are not obscured by the order table. - That the order table starts near the top of the second page, and not half way down. 10) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: Laura Escamilla Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 4e7dfa2fbacda38de4814fa3768c9eb6b0d481af) Signed-off-by: Pedro Amorim --- Koha/pdfformat/layout1page.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Koha/pdfformat/layout1page.pm b/Koha/pdfformat/layout1page.pm index e3b498325a..72aac83f76 100644 --- a/Koha/pdfformat/layout1page.pm +++ b/Koha/pdfformat/layout1page.pm @@ -103,8 +103,8 @@ sub printorders { x => 10/mm, w => ($width - 20)/mm, start_y => 170/mm, - next_y => 170/mm, - start_h => 260/mm, + next_y => 280/mm, + start_h => 150/mm, next_h => 260/mm, padding => 5, padding_right => 5, -- 2.39.5