From 3d21b002c12fcf39359782fb587ae05836b2b62e Mon Sep 17 00:00:00 2001
From: Lucas Gass <lucas@bywatersolutions.com>
Date: Fri, 7 Jul 2023 16:07:47 +0000
Subject: [PATCH] Bug 33620: Don't show guarantor info on details page if
 borrowerRelationship is empty

To test:
1. Apply patch
2. Have some values in borrowerRelationship.
3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:'
4. Now empty borrowerRelationship.
5. Visit the patron detail page again and you should no longer see either of those fields.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../prog/en/modules/members/moremember.tt     | 35 ++++++++++---------
 1 file changed, 18 insertions(+), 17 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
index 911d2ecece..6facce6e5c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ -188,24 +188,25 @@
                                                 </li>
                                             [% END %]
                                         [% END %]
-                                         <li id="patron-privacyguarantor">
-                                            <span class="label">Show checkouts to guarantor:</span>
-                                            [% IF patron.privacy_guarantor_checkouts %]
-                                                Yes
-                                            [% ELSE %]
-                                                No
-                                            [% END %]
-                                        </li>
-
-                                        <li id="patron-privacy_guarantor_fines">
-                                            <span class="label">Show charges to guarantor:</span>
-                                            [% IF patron.privacy_guarantor_fines %]
-                                                Yes
-                                            [% ELSE %]
-                                                No
-                                            [% END %]
-                                        </li>
+                                        [% IF Koha.Preference("borrowerRelationship") %]
+                                             <li id="patron-privacyguarantor">
+                                                <span class="label">Show checkouts to guarantor:</span>
+                                                [% IF patron.privacy_guarantor_checkouts %]
+                                                    Yes
+                                                [% ELSE %]
+                                                    No
+                                                [% END %]
+                                            </li>
 
+                                            <li id="patron-privacy_guarantor_fines">
+                                                <span class="label">Show charges to guarantor:</span>
+                                                [% IF patron.privacy_guarantor_fines %]
+                                                    Yes
+                                                [% ELSE %]
+                                                    No
+                                                [% END %]
+                                            </li>
+                                        [% END %]
                                         [% IF guarantees %]
                                             <li>
                                                 <span class="label">Guarantees:</span>
-- 
2.39.5