From 3da06bdd73fa576b735303205c8124d8580b6ec4 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 3 May 2023 11:16:14 +0200
Subject: [PATCH] Bug 32412: Do not reload COCE image for biblio

We do not want to fetch again the new image for the biblio record. We
only want to fetch those for the shelf browser.

Note that the third parameter 'covernewwindow' was not used.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 13dccaaf055b49473c1cc4a6ac34c0a23eb182a0)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 4 ++--
 koha-tmpl/opac-tmpl/bootstrap/js/coce.js                | 8 +++++---
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
index 55f2034ab5..6ba1010c48 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
@@ -1873,7 +1873,7 @@
                                     KOHA.Google.GetCoverFromIsbn([% covernewwindow | html %]);
                                 [% END %]
                                 [% IF ( Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) %]
-                                    KOHA.coce.getURL('[% Koha.Preference('CoceHost') | html %]', '[% Koha.Preference('CoceProviders') | html %]',[% covernewwindow | html %]);
+                                    KOHA.coce.getURL('[% Koha.Preference('CoceHost') | html %]', '[% Koha.Preference('CoceProviders') | html %]', $("#bibliodescriptions"));
                                 [% END %]
                                 [% IF OpenLibraryCovers %]
                                     KOHA.OpenLibrary.GetCoverFromIsbn();
@@ -1899,7 +1899,7 @@
                                     KOHA.Google.GetCoverFromIsbn([% covernewwindow | html %]);
                                 [% END %]
                                 [% IF ( Koha.Preference('OpacCoce') && Koha.Preference('CoceProviders') ) %]
-                                    KOHA.coce.getURL('[% Koha.Preference('CoceHost') | html %]', '[% Koha.Preference('CoceProviders') | html %]',[% covernewwindow | html %]);
+                                    KOHA.coce.getURL('[% Koha.Preference('CoceHost') | html %]', '[% Koha.Preference('CoceProviders') | html %]', $("#bibliodescriptions"));
                                 [% END %]
                                 [% IF OpenLibraryCovers %]
                                     KOHA.OpenLibrary.GetCoverFromIsbn();
diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/coce.js b/koha-tmpl/opac-tmpl/bootstrap/js/coce.js
index 65772380dd..8508d3a82b 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/js/coce.js
+++ b/koha-tmpl/opac-tmpl/bootstrap/js/coce.js
@@ -14,9 +14,11 @@ KOHA.coce = {
      * and run a search with all collected isbns to coce cover service.
      * The result is asynchronously returned, and used to append <img>.
      */
-    getURL: function(host, provider) {
+    getURL: function(host, provider, parent=null) {
         var ids = [];
-        $("[id^=coce-thumbnail]").each(function() {
+        const thumbnail_selector = "[id^=coce-thumbnail]";
+        let thumbnail_nodes = parent ? parent.find(thumbnail_selector) : $(thumbnail_selector);
+        thumbnail_nodes.each(function() {
             var id = $(this).attr("class"); // id=isbn
             if (id !== '') { ids.push(id); }
         });
@@ -40,7 +42,7 @@ KOHA.coce = {
                             }
                         };
                         $(this).attr('href', url);
-                        $(this).empty().append(img);
+                        $(this).append(img);
                     });
                 }
             },
-- 
2.39.5