From 42ed26660b7c8c05a66a99a1e458f303481119dd Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Tue, 23 Jan 2018 15:16:35 +0100
Subject: [PATCH] Bug 20074: Fix hidden value in auth_subfields_structure

The template included an else branch where a value not equal to 0 or -5
was interpreted as 0 (Show all).
This effectively converted hidden values 1 and 8 to 0.
This patch removes that else branch.

Test plan:
Toggle a authority field between Hide all and Show all. Check what happens.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../prog/en/modules/admin/auth_subfields_structure.tt       | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
index 2ea6465b34..b7a6ab2aa1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
@@ -113,12 +113,10 @@
                                     [%- IF ( loo.ohidden ==  0 ) -%]
                                     <option value= "0" selected="selected">Show all</option>
                                     <option value="-5">Hide all</option>
-                                    [%- ELSIF ( loo.ohidden == -5 ) -%]
-                                    <option value= "0">Show all</option>
-                                    <option value="-5" selected="selected">Hide all</option>
                                     [%- ELSE -%]
+                                    [%# All other non-zero values mean: Hide %]
                                     <option value= "0">Show all</option>
-                                    <option value="-5">Hide all</option>
+                                    <option value="-5" selected="selected">Hide all</option>
                                     [%- END -%]
                                 </select>
                             </li>
-- 
2.39.5