From 46939d0a1c3315dad4e9a27bdf73621a5b0b1db0 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 27 Apr 2016 09:37:06 -0400 Subject: [PATCH] Bug 16366 - Remove obsolete "border" attribute from tags MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch removes the obsolete "border" attribute from tags. Browsers haven't applied an border to images by default for years. There should be no visible changes as a result of this patch. It only affects HTML validation. If you want to test the affected pages, apply the patch and confirm that images look correct on these pages: - In the patron sidebar menu, if patron images are enabled. - On the authority MARC subfield structure administration page, only some obsolete markup is affected (See Bug 16367). - I don't know how to trigger display of the "filefind.png" image on authority and bibliographic detail pages. Possibly unused markup? - On the advanced search page, itemtype/collection/shelving location images should look correct. - When viewing existing holds for a title, the arrow images used for changing the position of a hold in the list should look correct. - When viewing a list of MARC modification actions, the arrow images used for changing the order of actions should look correct. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall --- .../intranet-tmpl/prog/en/includes/circ-menu.inc | 4 ++-- .../en/modules/admin/auth_subfields_structure.tt | 4 ++-- .../prog/en/modules/authorities/detail.tt | 2 +- .../prog/en/modules/catalogue/MARCdetail.tt | 2 +- .../prog/en/modules/catalogue/advsearch.tt | 2 +- .../prog/en/modules/catalogue/detail.tt | 4 ++-- .../prog/en/modules/reserve/request.tt | 16 ++++++++-------- .../modules/tools/marc_modification_templates.tt | 8 ++++---- 8 files changed, 21 insertions(+), 21 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc index 1d6dc9b774..9e4e7047e2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc @@ -8,9 +8,9 @@
    [% IF ( patronimages ) %] [% IF ( picture ) %] -
  • [% firstname %] [% surname %] ([% cardnumber %])
    • +
  • [% firstname %] [% surname %] ([% cardnumber %])
    • [% ELSE %] -
  • [% firstname %] [% surname %] ([% cardnumber %])
    • +
  • [% firstname %] [% surname %] ([% cardnumber %])
    • [% END %] [% END %] [% IF Koha.Preference( 'AddressFormat' ) %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt index b62de1ddda..a05043cfa8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt @@ -321,12 +321,12 @@ [% IF ( previous ) %] - + [% END %] [% IF ( next ) %] [% next %] - + [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt index 3b7f26222f..295c325369 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt @@ -125,7 +125,7 @@ function searchauthority() { [% subfiel.marc_value %] [% IF ( subfiel.link ) %] - + [% END %] [% IF ( subfiel.authority ) %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt index 4c0c115232..992bd0afc2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt @@ -93,7 +93,7 @@ function Changefwk(FwkList) { [% IF ( subfiel.is_url ) %][% subfiel.marc_value |html %][% ELSE %][% subfiel.marc_value |html %][% END %] [% IF ( subfiel.link ) %] - Search on [% subfiel.marc_value |html %] + Search on [% subfiel.marc_value |html %] [% END %] [% IF ( subfiel.authority ) %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt index 1349a80c61..eec5145f05 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt @@ -131,7 +131,7 @@ [% FOREACH itemtypeloo IN advsearchloo.code_loop %] - [% IF ( loop.last ) %][% ELSE %][% UNLESS ( loop.count % 5 ) %][% END %][% END %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index 17022dfe23..f7ed7c3c9c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -387,7 +387,7 @@ function verify_images() { [% IF ( AmazonCoverImages ) %] [% END %] [% END %] @@ -461,7 +461,7 @@ function verify_images() { [% IF ( AmazonCoverImages ) %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 6a2f6696d0..f6e5276aea 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -692,7 +692,7 @@ function checkMultiHold() { [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] - + [% END %] [% IF SuspendHoldsIntranet %][% END %] @@ -730,19 +730,19 @@ function checkMultiHold() { [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] [% END %] @@ -827,9 +827,9 @@ function checkMultiHold() { @@ -837,7 +837,7 @@ function checkMultiHold() { diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt index 8ca6b04f1c..8b28e90629 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt @@ -79,19 +79,19 @@ -- 2.39.5
    Pickup library DetailsToggle set to lowest priorityToggle set to lowest priority   - Go up + Go up - Go top + Go top - Go bottom + Go bottom - Go down + Go down [% IF ( reserveloo.lowestPriority ) %] - Unset lowest priority + Unset lowest priority [% ELSE %] - Set to lowest priority + Set to lowest priority [% END %] - Cancel + Cancel
    - Go up + Go up - Go top + Go top - Go bottom + Go bottom - Go down + Go down