From 49fb09b142b4d19637f2d347cf8e666a6bc8eb9c Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Mon, 2 May 2022 10:59:23 +0200
Subject: [PATCH] Bug 29897: Don't use $6 for linkage but build the link
 instead

See comment 26:
$6 is a very specialized field that will never contain a URL. Linkage here means 'linking MARC fields within the record'. For example it is used to link an original script tag with the corresponding tag in transliteration. See: https://www.loc.gov/marc/authority/ecadcntf.html

Sponsored-by: Orex Digital

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../bootstrap/en/modules/opac-auth-detail.tt  | 23 +++++++++++--------
 .../bootstrap/en/modules/opac-detail.tt       | 18 +++++++++++----
 2 files changed, 26 insertions(+), 15 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
index 6972b11915..bfcbbac48f 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt
@@ -188,16 +188,19 @@
                             [% FOR identifier IN author_identifiers %]
                                 <li>
                                 [% SWITCH identifier.source.lower %]
-                                [% CASE 'orcid' %]ORCID:
-                                [% CASE 'scopus' %]ScopusID:
-                                [% CASE 'loop' %]loop:
-                                [% CASE 'rid' %]Publons:
-                                [% CASE %][% identifier.source | html %]:
-                                [% END %]
-                                [% IF identifier.linkage %]
-                                    <a href="[% identifier.linkage | url %]">[% identifier.number | html %]</a>
-                                [% ELSE %]
-                                    [% identifier.number | html %]
+                                [% CASE 'orcid' %]
+                                    ORCID:
+                                    <a href="https://orcid.org/[% identifier.number | url %]">[% identifier.number | html %]</a>
+                                [% CASE 'scopus' %]
+                                    ScopusID:
+                                    <a href="https://www.scopus.com/authid/detail.uri?authorId=[% identifier.number | url %]">[% identifier.number | html %]</a>
+                                [% CASE 'loop' %]
+                                    loop:
+                                    <a href="https://loop.frontiersin.org/people/[% identifier.number | url %]">[% identifier.number | html %]</a>
+                                [% CASE 'rid' %]
+                                    Publons:
+                                    <a href="https://publons.com/researcher/[% identifier.number | url %]">[% identifier.number | html %]</a>
+                                [% CASE %][% identifier.source | html %]: [% identifier.number | html %]
                                 [% END %]
                                 </li>
                             [% END %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
index c3e97eaeb7..ca61006d84 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
@@ -967,11 +967,19 @@
                                             [% FOR identifier IN author.identifiers %]
                                                 <li>
                                                 [% SWITCH identifier.source.lower %]
-                                                [% CASE 'orcid' %]ORCID:
-                                                [% CASE 'scopus' %]ScopusID:
-                                                [% CASE 'loop' %]loop:
-                                                [% CASE 'rid' %]Publons:
-                                                [% CASE %][% identifier.source | html %]:
+                                                [% CASE 'orcid' %]
+                                                    ORCID:
+                                                    <a href="https://orcid.org/[% identifier.number | url %]">[% identifier.number | html %]</a>
+                                                [% CASE 'scopus' %]
+                                                    ScopusID:
+                                                    <a href="https://www.scopus.com/authid/detail.uri?authorId=[% identifier.number | url %]">[% identifier.number | html %]</a>
+                                                [% CASE 'loop' %]
+                                                    loop:
+                                                    <a href="https://loop.frontiersin.org/people/[% identifier.number | url %]">[% identifier.number | html %]</a>
+                                                [% CASE 'rid' %]
+                                                    Publons:
+                                                    <a href="https://publons.com/researcher/[% identifier.number | url %]">[% identifier.number | html %]</a>
+                                                [% CASE %][% identifier.source | html %]: [% identifier.number | html %]
                                                 [% END %]
                                                 [% IF identifier.linkage %]
                                                     <a href="[% identifier.linkage | url %]">[% identifier.number | html %]</a>
-- 
2.39.5