From 56fabf311711964eaa6b379c8145f59990314af2 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Sun, 17 Sep 2023 13:18:49 +0000 Subject: [PATCH] Bug 34789: (QA follow-up) Improve output of database update * Adds description * Adds column names to success messages Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit c1b344b002b3ff2471c72f18a9746f71f7900978) Signed-off-by: Fridolin Somers (cherry picked from commit ab85941b5f8dc9dbd4084031c5388e58f78d7da0) Signed-off-by: Matt Blenkinsop --- .../data/mysql/atomicupdate/bug_34789-rename-column.pl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/installer/data/mysql/atomicupdate/bug_34789-rename-column.pl b/installer/data/mysql/atomicupdate/bug_34789-rename-column.pl index f305f27ffa..196abd70c7 100755 --- a/installer/data/mysql/atomicupdate/bug_34789-rename-column.pl +++ b/installer/data/mysql/atomicupdate/bug_34789-rename-column.pl @@ -2,7 +2,7 @@ use Modern::Perl; return { bug_number => "34789", - description => "A single line description", + description => "Correct datatypes and column name in table erm_eholdings_titles", up => sub { my ($args) = @_; my ( $dbh, $out ) = @$args{qw(dbh out)}; @@ -13,7 +13,7 @@ return { ALTER TABLE erm_eholdings_titles RENAME COLUMN preceeding_publication_title_id TO preceding_publication_title_id } ); - say $out 'Column renamed to preceding_publication_title_id'; + say $out 'Column preceeding_publication_title renamed to preceding_publication_title_id'; } if ( column_exists( 'erm_eholdings_titles', 'publication_title' ) ) { $dbh->do( @@ -21,7 +21,7 @@ return { ALTER TABLE erm_eholdings_titles MODIFY COLUMN publication_title mediumtext } ); - say $out 'Column datatype amended to mediumtext'; + say $out 'Column publication_title datatype amended to mediumtext'; } if ( column_exists( 'erm_eholdings_titles', 'notes' ) ) { $dbh->do( @@ -29,7 +29,7 @@ return { ALTER TABLE erm_eholdings_titles MODIFY COLUMN notes mediumtext } ); - say $out 'Column datatype amended to mediumtext'; + say $out 'Column notes datatype amended to mediumtext'; } }, }; -- 2.39.5