From 5e4d80ce6f49ff5a3ba9930e2c51f1bffb066b43 Mon Sep 17 00:00:00 2001 From: Mason James Date: Wed, 27 Jun 2012 01:12:24 +1200 Subject: [PATCH] =?utf8?q?Bug=206679=20-=20[SIGNED-OFF]=C2=A0fix=209=20per?= =?utf8?q?lcritic=20violations=20in=20C4/Koha.pm?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit - Subroutine prototypes used at line 115, column 1. See page 194 of PBP. (Severity: 5) - "return" statement with explicit "undef" at line 1112, column 4. See page 199 of PBP. (Severity: 5) Signed-off-by: Jonathan Druart Signed-off-by: Paul Poulain --- C4/Koha.pm | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/C4/Koha.pm b/C4/Koha.pm index 4d98fd519c..07c80c69ac 100644 --- a/C4/Koha.pm +++ b/C4/Koha.pm @@ -112,7 +112,7 @@ sub slashifyDate { } # FIXME.. this should be moved to a MARC-specific module -sub subfield_is_koha_internal_p ($) { +sub subfield_is_koha_internal_p { my ($subfield) = @_; # We could match on 'lib' and 'tab' (and 'mandatory', & more to come!) @@ -471,7 +471,7 @@ sub getitemtypeimagesrc { } } -sub getitemtypeimagelocation($$) { +sub getitemtypeimagelocation { my ( $src, $image ) = @_; return '' if ( !$image ); @@ -630,7 +630,7 @@ sub GetPrinters { =cut -sub GetPrinter ($$) { +sub GetPrinter { my ( $query, $printers ) = @_; # get printer for this query from printers my $printer = $query->param('printer'); my %cookie = $query->cookie('userenv'); @@ -1127,7 +1127,7 @@ sub GetKohaAuthorisedValues { } return \%values; } else { - return undef; + return; } } @@ -1158,7 +1158,7 @@ sub GetKohaAuthorisedValuesFromField { } return \%values; } else { - return undef; + return; } } @@ -1260,7 +1260,7 @@ sub GetNormalizedISBN { $isbn =~ s/(.*)( \| )(.*)/$1/; return _isbn_cleanup($isbn); } - return undef unless $record; + return unless $record; if ($marcflavour eq 'UNIMARC') { @fields = $record->field('010'); @@ -1269,7 +1269,7 @@ sub GetNormalizedISBN { if ($isbn) { return _isbn_cleanup($isbn); } else { - return undef; + return; } } } @@ -1280,7 +1280,7 @@ sub GetNormalizedISBN { if ($isbn) { return _isbn_cleanup($isbn); } else { - return undef; + return; } } } @@ -1325,7 +1325,7 @@ sub GetNormalizedOCLCNumber { $oclc =~ s/\(OCoLC\)//; return $oclc; } else { - return undef; + return; } } } -- 2.39.5