From 63504e325ddf6db61252d94b6d5829bb87628358 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Mon, 6 Mar 2023 20:03:14 +0000 Subject: [PATCH] Bug 8367: (QA follow-up) Improve display when value not set for rule When a rule is not set for a speficic line, the value in the syspref will be used. This should be made clear in the interface. To test: 1 - Add a new rule for a specific item type 2 - Do not fill the 'Hold pickup period' 3 - Confirm that the rule defaults to the system preference 4 - Hover on 'Default' in the circ rules under 'Hold pickup period' 5 - Confirm the text is readable Signed-off-by: Nick Clemens Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Kelly Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index 65937015f4..feed1f5b5a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -372,7 +372,13 @@ Don't allow [% END %] - [% holds_pickup_period | html %] + + [% IF holds_pickup_period == '' %] + Default + [% ELSE %] + [% holds_pickup_period | html %] + [% END %] + [% IF Koha.Preference('ArticleRequests') %] [% IF article_requests == 'no' %] -- 2.39.5