From 651e8a3fad061808b5c16f0197cb2b1c208f085d Mon Sep 17 00:00:00 2001 From: Jared Camins-Esakov Date: Tue, 22 Jan 2013 18:40:25 -0500 Subject: [PATCH] Bug 9451: Quiet warnings and Plackify borrower_stats.pl There are several warnings and one non-Plack-compatible variable in reports/borrower_stats.pl. To test: 1) Apply patch 2) Use the borrower report wizard to create a report that includes an extended patron attribute. 3) Check the logs, and make sure that you don't see any of the following messages: Variable "$period" is not available at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Jared Camins-Esakov --- reports/borrowers_stats.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/reports/borrowers_stats.pl b/reports/borrowers_stats.pl index 9454fc5b06..8181285448 100755 --- a/reports/borrowers_stats.pl +++ b/reports/borrowers_stats.pl @@ -56,7 +56,7 @@ my @filters = $input->param("Filter"); $filters[3]=format_date_in_iso($filters[3]); $filters[4]=format_date_in_iso($filters[4]); my $digits = $input->param("digits"); -my $period = $input->param("period"); +our $period = $input->param("period"); my $borstat = $input->param("status"); my $borstat1 = $input->param("activity"); my $output = $input->param("output"); @@ -372,6 +372,7 @@ sub calculate { my $coltitle = $row->{coltitle} // ''; $table{$rowtitle}->{$coltitle} = 0; } + $row->{rowtitle} ||= ''; $table{$row->{rowtitle}}->{totalrow}=0; $table{$row->{rowtitle}}->{rowtitle_display} = $row->{rowtitle_display}; } -- 2.39.5