From 689f1f9b1f5f53c18c2a351f0fb2195631749de6 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 23 Oct 2020 13:54:01 +0000
Subject: [PATCH] Bug 26799: Remove the use of jquery.checkboxes plugin from
 patron payment page

This patch removes the use of the jquery.checkboxes plugin from the
patron payment screen (members/pay.tt).

To test, apply the patch and locate a patron with unpaid fines.

- View the "Accounting" page for that patron.
- In the table of outstanding fines, test the "Select all" and "Clear
  all" links work correctly to check the checkboxes corresponding to
  each fine.
- Confirm that the "Select all" action enables the "Pay selected" and
  "Write off selected" buttons.
- Confirm that the "Clear all" action disables the "Pay selected" and
  "Write off selected" buttons.

Signed-off-by: Lisette Scheer <lisettes@latahlibrary.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../intranet-tmpl/prog/en/modules/members/pay.tt      | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
index f42ad63774..f151c65dfd 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
@@ -172,7 +172,6 @@
 [% MACRO jsinclude BLOCK %]
     [% INCLUDE 'str/members-menu.inc' %]
     [% Asset.js("js/members-menu.js") | $raw %]
-    [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
     [% INCLUDE 'datatables.inc' %]
     [% INCLUDE 'columns_settings.inc' %]
     <script>
@@ -200,15 +199,17 @@
             });
             $('#CheckAll').click(function(e){
                 e.preventDefault();
-                $("#finest").checkCheckboxes();
+                $(".cb").each(function(){
+                    $(this).prop("checked", true );
+                });
                 enableCheckboxActions();
-                return false;
             });
             $('#CheckNone').click(function(e){
                 e.preventDefault();
-                $("#finest").unCheckCheckboxes();
+                $(".cb").each(function(){
+                    $(this).prop("checked", false );
+                });
                 enableCheckboxActions();
-                return false;
             });
             $(".cb").change(function(){
                 enableCheckboxActions();
-- 
2.39.5