From 6f4f32f4bc1f2176c60fe34cf37b3822f08481aa Mon Sep 17 00:00:00 2001 From: =?utf8?q?Marc=20V=C3=A9ron?= Date: Fri, 30 Sep 2016 17:48:44 +0200 Subject: [PATCH] Bug 17384 - Categories do not display in patron editing form if they have only one category assigned To reproduce: - Go to Home > Administration > Patron categories - Make sure that you have only one category for a category type. Examples: Only one category "Staff" for category type "Staff" or Only one category "Library" for category type "Org." - Edit a patron or create a new patron - Verify that categories of examples above do not show up in category drop down - Go back to Home > Administration > Patron categories and add categories to both category types - Edit or create a new patron. Veryfy that categories show up in dropdown. To test: - Apply patch - Make sure you have a category type with only one category assigned (e.g. category taype Staff with category Staff) - Edit a patron or create a new patron. Verify that the category shows up in categroy drop down. - Additional test: Verify that template param 'catcode' from removed line is not used in template memberentrygen.tt Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Brendan Gallagher --- members/memberentry.pl | 1 - 1 file changed, 1 deletion(-) diff --git a/members/memberentry.pl b/members/memberentry.pl index 1b100b0b99..8fc5d9bf5e 100755 --- a/members/memberentry.pl +++ b/members/memberentry.pl @@ -524,7 +524,6 @@ my $no_add; foreach my $category_type (qw(C A S P I X)) { my $patron_categories = Koha::Patron::Categories->search_limited({ category_type => $category_type }, {order_by => ['categorycode']}); $no_categories = 0 if $patron_categories->count > 0; - $template->param( 'catcode' => $patron_categories->next ) if $patron_categories->count == 1; my @categoryloop; while ( my $patron_category = $patron_categories->next ) { -- 2.39.5