From 77f43b1a636c1dbde09caa598f6e03990e24cf39 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Thu, 8 Feb 2024 09:50:12 +0100
Subject: [PATCH] Bug 34478: Replace forms with links - authorities/authorities

Bug 34478: [TO SQUASH] Replace forms with links - authorities/authorities

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 authorities/authorities.pl                          |  3 ++-
 .../prog/en/modules/authorities/authorities.tt      | 13 ++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/authorities/authorities.pl b/authorities/authorities.pl
index 91ea5d9d2a..0d19045ebb 100755
--- a/authorities/authorities.pl
+++ b/authorities/authorities.pl
@@ -597,7 +597,8 @@ if ($op eq "cud-add") {
     my $record = TransformHtmlToMarc($input, 0);
 
     my ($duplicateauthid,$duplicateauthvalue);
-     ($duplicateauthid,$duplicateauthvalue) = FindDuplicateAuthority($record,$authtypecode) if ($op eq "cud-add") && (!$is_a_modif);
+    ( $duplicateauthid, $duplicateauthvalue ) = FindDuplicateAuthority( $record, $authtypecode ) unless $is_a_modif;
+
     my $confirm_not_duplicate = $input->param('confirm_not_duplicate');
     # it is not a duplicate (determined either by Koha itself or by user checking it's not a duplicate)
     if (!$duplicateauthid or $confirm_not_duplicate) {
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
index f9d27a0b44..8c03d9967a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
@@ -419,13 +419,12 @@
                         <h3>Duplicate record suspected</h3>
                         <p>Is this a duplicate of <a href="/cgi-bin/koha/authorities/detail.pl?authid=[% duplicateauthid | uri %]" class="popup" onclick="openWindow('/cgi-bin/koha/authorities/detail.pl?authid=[% duplicateauthid | html %]&amp;popup=1', 'DuplicateAuthority','800','600'); return false;" class="button">[% duplicateauthvalue | html %]</a> ?</p>
 
-                        <form action="authorities.pl" method="post">
-                            <input type="hidden" name="authid" value="[% duplicateauthid | html %]" />
-                            <button type="submit" class="new"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Yes: Edit existing authority</button>
-                        </form>
-                        <form action="authorities.pl" method="post">
-                            <button class="new" onclick="confirmnotdup('items'); return false;"><i class="fa fa-save"></i> No: Save as new authority</button>
-                        </form>
+                        <p>
+                            <a href="/cgi-bin/koha/authorities/authorities.pl?authid=[% duplicateauthid | uri %]" class="btn btn-default" class="new"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Yes: Edit existing authority</a>
+                        </p>
+                        <p>
+                            <a class="btn btn-default new" onclick="confirmnotdup('items'); return false;"><i class="fa fa-save"></i> No: Save as new authority</a>
+                        </p>
                     </div>
                 [% END # /IF duplicateauthid %]
 
-- 
2.39.5