From 7b2cd8e636a5b2eda0c405c2198eb09c2c35e22c Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Mon, 15 Aug 2011 15:22:21 -0400
Subject: [PATCH] Follow-up to Bug 4868, Improve controls for cloning and
 deleting subfields

- Adding similar icons for cloning and deleting tags
- Adding icon for the "Tag editor" links ("...")

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
---
 cataloguing/addbiblio.pl                          |  10 +++++-----
 .../prog/en/modules/cataloguing/addbiblio.tt      |   5 +++--
 koha-tmpl/intranet-tmpl/prog/img/delete-tag.png   | Bin 0 -> 244 bytes
 koha-tmpl/intranet-tmpl/prog/img/edit-tag.png     | Bin 0 -> 264 bytes
 koha-tmpl/intranet-tmpl/prog/img/repeat-tag.png   | Bin 0 -> 244 bytes
 5 files changed, 8 insertions(+), 7 deletions(-)
 create mode 100644 koha-tmpl/intranet-tmpl/prog/img/delete-tag.png
 create mode 100644 koha-tmpl/intranet-tmpl/prog/img/edit-tag.png
 create mode 100644 koha-tmpl/intranet-tmpl/prog/img/repeat-tag.png

diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
index e912c667cb..b4d1e99d14 100755
--- a/cataloguing/addbiblio.pl
+++ b/cataloguing/addbiblio.pl
@@ -388,8 +388,8 @@ sub create_input {
                     size=\"67\"
                     maxlength=\"$max_length\"
                     \/>
-                    <a href=\"#\" class=\"buttonDot\"
-                        onclick=\"openAuth(this.parentNode.getElementsByTagName('input')[1].id,'".$tagslib->{$tag}->{$subfield}->{authtypecode}."'); return false;\" tabindex=\"1\" title=\"Tag Editor\">...</a>
+                    <span class=\"subfield_controls\"><a href=\"#\" class=\"buttonDot\"
+                       onclick=\"openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id,'".$tagslib->{$tag}->{$subfield}->{authtypecode}."'); return false;\" tabindex=\"1\" title=\"Tag Editor\"><img src=\"/intranet-tmpl/prog/img/edit-tag.png\" alt=\"Tag Editor\" /></a></span>
             ";
       } else {
         $subfield_data{marc_value} =
@@ -402,8 +402,8 @@ sub create_input {
                     size=\"67\"
                     maxlength=\"$max_length\"
                     readonly=\"readonly\"
-                    \/><a href=\"#\" class=\"buttonDot\"
-                        onclick=\"openAuth(this.parentNode.getElementsByTagName('input')[1].id,'".$tagslib->{$tag}->{$subfield}->{authtypecode}."'); return false;\" tabindex=\"1\" title=\"Tag Editor\">...</a>
+                    \/><span class=\"subfield_controls\"><a href=\"#\" class=\"buttonDot\"
+                        onclick=\"openAuth(this.parentNode.parentNode.getElementsByTagName('input')[1].id,'".$tagslib->{$tag}->{$subfield}->{authtypecode}."'); return false;\" tabindex=\"1\" title=\"Tag Editor\"><img src=\"/intranet-tmpl/prog/img/edit-tag.png\" alt=\"Tag Editor\" /></a></span>
             ";
       }
     # it's a plugin field
@@ -433,7 +433,7 @@ sub create_input {
                             size=\"67\"
                             maxlength=\"$max_length\"
                             onblur=\"Blur$function_name($index_tag); \" \/>
-                            <a href=\"#\" class=\"buttonDot\" onclick=\"Clic$function_name('$subfield_data{id}'); return false;\" tabindex=\"1\" title=\"Tag Editor\">...</a>
+                            <span class=\"subfield_controls\"><a href=\"#\" class=\"buttonDot\" onclick=\"Clic$function_name('$subfield_data{id}'); return false;\" tabindex=\"1\" title=\"Tag Editor\"><img src=\"/intranet-tmpl/prog/img/edit-tag.png\" alt=\"Tag Editor\" /></a></span>
                     $javascript";
         } else {
             warn "Plugin Failed: $plugin";
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
index ffe7d3c0f0..71e61335ca 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
@@ -845,9 +845,10 @@ function unHideSubfield(index,labelindex) { // FIXME :: is it used ?
 	            <a href="#" tabindex="1" class="expandfield" onclick="ExpandField('tag_[% innerloo.tag %]_[% innerloo.index %][% innerloo.random %]'); return false;" title="Click to Expand this Tag">[% innerloo.tag_lib %]</a>
             [% END %]
             [% IF ( innerloo.repeatable ) %]
-                <a href="#" tabindex="1" class="buttonPlus" onclick="CloneField('tag_[% innerloo.tag %]_[% innerloo.index %][% innerloo.random %]'); return false;" title="Repeat this Tag">+</a>
+                <span class="subfield_controls"><a href="#" tabindex="1" class="buttonPlus" onclick="CloneField('tag_[% innerloo.tag %]_[% innerloo.index %][% innerloo.random %]'); return false;" title="Repeat this Tag"><img src="/intranet-tmpl/prog/img/repeat-tag.png" alt="Repeat this Tag" /></a>
             [% END %]
-                <a href="#" tabindex="1" class="buttonMinus" onclick="UnCloneField('tag_[% innerloo.tag %]_[% innerloo.index %][% innerloo.random %]'); return false;" title="Delete this Tag">&#8722;</a>
+                <a href="#" tabindex="1" class="buttonMinus" onclick="UnCloneField('tag_[% innerloo.tag %]_[% innerloo.index %][% innerloo.random %]'); return false;" title="Delete this Tag"><img src="/intranet-tmpl/prog/img/delete-tag.png" alt="Delete this Tag" /></a></span>
+
             
         </div>
 	
diff --git a/koha-tmpl/intranet-tmpl/prog/img/delete-tag.png b/koha-tmpl/intranet-tmpl/prog/img/delete-tag.png
new file mode 100644
index 0000000000000000000000000000000000000000..ca56230b73f6419821949891461a742b1756f8d8
GIT binary patch
literal 244
zcmeAS@N?(olHy`uVBq!ia0vp^0zk~e!3-p0EYEHRQY`6?zK#qG>ra@ocD)4hB}-f*
zN`mv#O3D+9QW+dm@{>{(JaZG%Q-e|yQz{EjrrLl^2=EDU{r~^}8Dry_GiL%BLiUrV
zfeb4N@(TuX8631$egX31JY5_^DsCkuxG^&@9%;~H5O8o{RI^~<WMC2SXkg?zz{J4F
zBF5mP=H|wxke0^Aq0qwR<|Z&-QlVkO8HUd@8JRc|xkFeT7z`DD2=E9vNW5d<P~c%~
gU^pbez+u3!iJS34_OyTeK${pmUHx3vIVCg!07z&<)Bpeg

literal 0
HcmV?d00001

diff --git a/koha-tmpl/intranet-tmpl/prog/img/edit-tag.png b/koha-tmpl/intranet-tmpl/prog/img/edit-tag.png
new file mode 100644
index 0000000000000000000000000000000000000000..b887870911c880293b6bbd8310a4e80a5d11fe49
GIT binary patch
literal 264
zcmeAS@N?(olHy`uVBq!ia0vp^0wB!63?wyl`GbKJOS+@4BLl<w6XvX4FM)i?64!{5
z;QX|b^2DN42FH~Aq*MjZ+{E<Mpwz^a%EFVWHb6x@0X`wFX=!OQXU_Z&23~7E9RwLx
z666;Q6ku@BTKNUYFY<J845_%4l;Fn9z<8uVk3qmef{B5#MG?s0d12GQz@+46kpKj2
z910T{ghdPt7%PF&Dh$tznOOv!7*@;^)Bq|y!Q`XB2vp4NaF&Iefkj}`!UQ1KX``45
n$Ur?-4h0?{|BwI!hXI4{8>Z9~VG_|m+ZjAv{an^LB{Ts5F0n@#

literal 0
HcmV?d00001

diff --git a/koha-tmpl/intranet-tmpl/prog/img/repeat-tag.png b/koha-tmpl/intranet-tmpl/prog/img/repeat-tag.png
new file mode 100644
index 0000000000000000000000000000000000000000..83a373167a06e4386cb1f2327ff8dd0abacde5be
GIT binary patch
literal 244
zcmeAS@N?(olHy`uVBq!ia0vp^0zk~e!3-p0EYEHRQY`6?zK#qG>ra@ocD)4hB}-f*
zN`mv#O3D+9QW+dm@{>{(JaZG%Q-e|yQz{EjrrLl^2=EDUojG%6T3XtFFsS<7-VQRX
zB*-rqD8S&Lweky)ALr@f7*cU7DZ!1If$>O#9)o~`10$OS11AHEfJXx-*8wI5Mi#Mz
z7Us0H28Je%16LSW8JIY7*p!8tg-`HIU~ph){HnN`fkUB#VUi>RW6MLn28KfdKt2y+
c0|PU|GH%9={O@zDfi^LCy85}Sb4q9e0Qw$91^@s6

literal 0
HcmV?d00001

-- 
2.39.5