From 7c9a2beb9d89beb37aa93d6b1cf745c4f5a56aa1 Mon Sep 17 00:00:00 2001 From: Andrew Fuerste Henry Date: Wed, 29 Nov 2023 18:02:52 +0000 Subject: [PATCH] Bug 25835: Include overdues with fines in overdues_report permission To test: 1 - have a user with circulate_remaining_permissions but not overdues_report 2 - confirm user can see and run Overdues with Fines 3 - apply patch 4 - confirm user can no longer see links to Overdues with Fines or load the page directly by entering the url 5 - confirm a user with overdues_report or greate permission can see and use the tool Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer (cherry picked from commit 23de67a7e4d3701f9a665ec0fee38e22128c5fa3) Signed-off-by: Fridolin Somers (cherry picked from commit 9825c7ea36ef823034b82acc168b6e38730cd9b0) Signed-off-by: Lucas Gass --- circ/branchoverdues.pl | 2 +- koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc | 4 ++-- .../intranet-tmpl/prog/en/modules/circ/circulation-home.tt | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/circ/branchoverdues.pl b/circ/branchoverdues.pl index 84414ded33..bce79d8cf8 100755 --- a/circ/branchoverdues.pl +++ b/circ/branchoverdues.pl @@ -42,7 +42,7 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user({ template_name => "circ/branchoverdues.tt", query => $input, type => "intranet", - flagsrequired => { circulate => "circulate_remaining_permissions" }, + flagsrequired => { circulate => "overdues_report" }, }); my $default = C4::Context->userenv->{'branch'}; diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc index e10a480589..83372281df 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-nav.inc @@ -109,16 +109,16 @@ + [% IF ( CAN_user_circulate_overdues_report ) %]
Overdues
+ [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt index b5ace5ebe9..8f0ac82f39 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tt @@ -135,17 +135,16 @@ + [% IF ( CAN_user_circulate_overdues_report ) %]

Overdues

+ [% END %]
-- 2.39.5