From 8d55afc04e3f9a43dcf8e17f3eace7b55f156034 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 7 Sep 2023 17:24:24 +0100 Subject: [PATCH] Bug 34737: (follow-up) Squelch a warning We weren't checking whether an item property was defined or not and as such the new test highlighted a new warning. Signed-off-by: Toni Ford Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi --- C4/SIP/ILS/Transaction/Checkin.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm index 63e017018f..bf4a17720a 100644 --- a/C4/SIP/ILS/Transaction/Checkin.pm +++ b/C4/SIP/ILS/Transaction/Checkin.pm @@ -292,6 +292,7 @@ sub _get_sort_bin { # Check the fields against values in the item my $property = $item->$item_property; + next RULE unless defined($property); if ( ( $comparator eq 'eq' || $comparator eq '=' ) && ( $property eq $value ) ) { $match = 1; } elsif ( ( $comparator eq 'ne' || $comparator eq '!=' ) && ( $property ne $value ) ) { -- 2.39.5