From 8e4d5279703be5f8e9313f2e497bfa98b58e422c Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Thu, 23 Feb 2023 21:21:02 +0000
Subject: [PATCH] Bug 33059: Fix capitalizatoin of AV sample category
 descriptions

* Fixes capitalization
* Standardizes on e-book (see https://www.oxfordlearnersdictionaries.com/definition/english/e-book)
* Standardizes on audiobook (see https://www.oxfordlearnersdictionaries.com/definition/english/audiobook)

To test:
* This is a little difficult to test. What you'd need to do:
* Apply the patch
* Drop your database, recreate it, run the web installer
* Make sure to select the optional AV along with the mandatory to install
* Log into Koha after finishing the installer and go to administration >
  authorised values
* Review the existing sample values for incorrect capitalization in
  the different categories

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../data/mysql/en/mandatory/auth_values.yml   |  8 ++---
 installer/data/mysql/en/optional/auth_val.yml | 36 +++++++++----------
 2 files changed, 22 insertions(+), 22 deletions(-)

diff --git a/installer/data/mysql/en/mandatory/auth_values.yml b/installer/data/mysql/en/mandatory/auth_values.yml
index 41c931e96c..5bfea57674 100644
--- a/installer/data/mysql/en/mandatory/auth_values.yml
+++ b/installer/data/mysql/en/mandatory/auth_values.yml
@@ -256,7 +256,7 @@ tables:
 
         - category: "ERM_TITLE_PUBLICATION_TYPE"
           authorised_value: "audiobook"
-          lib: "AudioBook"
+          lib: "Audiobook"
 
   # Country codes
   - authorised_values:
@@ -4045,8 +4045,8 @@ tables:
 
         - category: "qualif"
           authorised_value: "110"
-          lib: "Binder An agent who binds an item."
-          lib_opac: "Binder An agent who binds an item."
+          lib: "Binder an agent who binds an item."
+          lib_opac: "Binder an agent who binds an item."
 
         - category: "qualif"
           authorised_value: "120"
@@ -4276,7 +4276,7 @@ tables:
         - category: "qualif"
           authorised_value: "385"
           lib: "Former Attributed author"
-          lib_opac: "Former Attributed author"
+          lib_opac: "Former attributed author"
 
         - category: "qualif"
           authorised_value: "390"
diff --git a/installer/data/mysql/en/optional/auth_val.yml b/installer/data/mysql/en/optional/auth_val.yml
index 41c1cec9e6..62197838f9 100644
--- a/installer/data/mysql/en/optional/auth_val.yml
+++ b/installer/data/mysql/en/optional/auth_val.yml
@@ -33,11 +33,11 @@ tables:
 
         - category: "SUGGEST"
           authorised_value: "SCD"
-          lib: "Shelf Copy Damaged"
+          lib: "Shelf copy damaged"
 
         - category: "SUGGEST"
           authorised_value: "LCL"
-          lib: "Library Copy Lost"
+          lib: "Library copy lost"
 
         - category: "SUGGEST"
           authorised_value: "AVILL"
@@ -72,8 +72,8 @@ tables:
 
         - category: "SUGGEST_FORMAT"
           authorised_value: "EBOOK"
-          lib: "EBook"
-          lib_opac: "Ebook"
+          lib: "E-book"
+          lib_opac: "E-book"
 
         - category: "SUGGEST_FORMAT"
           authorised_value: "AUDIOBOOK"
@@ -92,7 +92,7 @@ tables:
         # availability statuses
         - category: "LOST"
           authorised_value: "2"
-          lib: "Long Overdue (Lost)"
+          lib: "Long overdue (lost)"
 
         - category: "LOST"
           authorised_value: "1"
@@ -100,7 +100,7 @@ tables:
 
         - category: "LOST"
           authorised_value: "3"
-          lib : "Lost and Paid For"
+          lib : "Lost and paid for"
 
         - category: "LOST"
           authorised_value: "4"
@@ -122,27 +122,27 @@ tables:
 
         - category: "LOC"
           authorised_value: "CHILD"
-          lib: "Children's Area"
+          lib: "Children's area"
 
         - category: "LOC"
           authorised_value: "DISPLAY"
-          lib: "On Display"
+          lib: "On display"
 
         - category: "LOC"
           authorised_value: "NEW"
-          lib: "New Materials Shelf"
+          lib: "New materials shelf"
 
         - category: "LOC"
           authorised_value: "STAFF"
-          lib: "Staff Office"
+          lib: "Staff office"
 
         - category: "LOC"
           authorised_value: "GEN"
-          lib: "General Stacks"
+          lib: "General stacks"
 
         - category: "LOC"
           authorised_value: "AV"
-          lib: "Audio Visual"
+          lib: "Audio visual"
 
         - category: "LOC"
           authorised_value: "REF"
@@ -150,11 +150,11 @@ tables:
 
         - category: "LOC"
           authorised_value: "CART"
-          lib: "Book Cart"
+          lib: "Book cart"
 
         - category: "LOC"
           authorised_value: "PROC"
-          lib: "Processing Center"
+          lib: "Processing center"
 
         # collection codes for an item
         - category: "CCODE"
@@ -181,11 +181,11 @@ tables:
 
         - category: "NOT_LOAN"
           authorised_value: "1"
-          lib: "Not For Loan"
+          lib: "Not for loan"
 
         - category: "NOT_LOAN"
           authorised_value: "2"
-          lib: "Staff Collection"
+          lib: "Staff collection"
 
         - category: "NOT_LOAN"
           authorised_value: "3"
@@ -194,12 +194,12 @@ tables:
         # restricted status of an item,linked to items.restricted
         - category: "RESTRICTED"
           authorised_value: "1"
-          lib: "Restricted Access"
+          lib: "Restricted access"
 
         # custom borrower notes
         - category: "BOR_NOTES"
           authorised_value: "ADDR"
-          lib: "Address Notes"
+          lib: "Address notes"
 
   - authorised_values:
       translatable: [ lib, lib_opac ]
-- 
2.39.5