From a6c67ada11da466c4249a95e236a535e62070890 Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Mon, 22 May 2023 08:46:31 +0000
Subject: [PATCH] Bug 33833: Add two FIXMEs to SocialData::get_report

Just comments, no test plan.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 C4/SocialData.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/C4/SocialData.pm b/C4/SocialData.pm
index 8217ccb49e..8a9c123529 100644
--- a/C4/SocialData.pm
+++ b/C4/SocialData.pm
@@ -120,7 +120,7 @@ sub get_report {
 
     my $sth = $dbh->prepare( qq{
         SELECT biblionumber, isbn FROM biblioitems
-    } );
+    } ); # FIXME We could better join socialdata here than call get_data for each record?
     $sth->execute;
     my %results;
     while ( my ( $biblionumber, $isbn ) = $sth->fetchrow() ) {
@@ -135,7 +135,7 @@ sub get_report {
         };
         next if $@;
         $isbn =~ s/-//g;
-        my $social_datas = C4::SocialData::get_data( $isbn );
+        my $social_datas = C4::SocialData::get_data( $isbn ); # FIXME Why is data not included in $results ?
         if ( $social_datas ) {
             push @{ $results{with} }, { biblionumber => $biblionumber, isbn => $isbn, original => $original_isbn };
         } else {
-- 
2.39.2