From b379bba255e32d6fcd7f8b053e58c2bc23491926 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Mon, 11 Feb 2019 13:35:12 +0000
Subject: [PATCH] Bug 10659: (follow-up) Ensure zero rating shows correctly

This patch makes a minor markup addition to ensure that a title with no
rating shows no stars.

Also changed: Minor addition to search results JS to prevent unwanted
scrolling if the user clicks a star in a star rating.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt  | 5 ++++-
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 4 ++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
index 05ff1bc4c9..46c1c76cb1 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
@@ -477,11 +477,14 @@
                                 [% ELSE %]
                                     <select id="star_rating" name="rating" data-rating-enabled="0" disabled="disabled" autocomplete="off">
                                 [% END %]
+                                    [% IF ( rating_avg_int == 0 ) %]
+                                        <option value="" selected="selected"></option>
+                                    [% END %]
                                     [% FOREACH i IN [ 1 2 3 4 5  ] %]
                                         [% IF rating_avg_int == i %]
                                             <option value="[% i | html %]" selected="selected">[% i | html %]</option>
                                         [% ELSE %]
-                                            <option value"[% i | html %]">[% i | html %]</option>
+                                            <option value="[% i | html %]">[% i | html %]</option>
                                         [% END %]
                                     [% END %]
                                 </select>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
index c4af74537d..20f0f1c6fc 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
@@ -738,6 +738,10 @@ $(document).ready(function(){
     });
     enableCheckboxActions();
 
+    $(".br-readonly a").on("click", function(e){
+        e.preventDefault();
+    });
+
     [% IF ( IDreamBooksResults ) %]
         $('.idbresult').each(function() {
             var isbn = $(this).children('a').text().replace(/\s*/,'');
-- 
2.39.5