From c3dd4d8e32beaa3ede51b48d1f71cbc4cb067965 Mon Sep 17 00:00:00 2001 From: Kevin Carnes Date: Fri, 18 Aug 2023 13:37:51 +0200 Subject: [PATCH] Bug 27496: Accessibility: Navigation buttons are poorly described by screen readers This patch adds aria-haspopup and aria-expanded attributes to the language and welcome user buttons so that screen readers will know that they cause a popup menu to be displayed. To test: 1. Use an installation with at least 2 active languages 2. Log in the OPAC 3. Use a screen reader (e.g. ChromeVox in Chrome) and use the tab key to navigate to the language and welcome user buttons while noticing that they are described as "Button collapsed" and "Button", respectively 4. Alternatively, inspect the buttons and notice that they are missing aria-haspopup and aria-expanded attributes 5. Apply the patch 6. Observe that these buttons now are described as "Popup button collapsed" or that they contain the aria-haspopup and aria-expanded attributes like the lists button 7. Sign off Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit e0007bf3623a6e58091eb233c95610761ac33a9e) Signed-off-by: Fridolin Somers (cherry picked from commit c3c0f9eb12a347b32cef6ac76b560cdb1ae3a084) Signed-off-by: Matt Blenkinsop --- koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc index c80d978837..de27ee097b 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-langmenu.inc @@ -3,7 +3,7 @@
  • - Languages +
  • [% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) %] [% IF ( loggedinusername ) %] - + -- 2.39.2