From c925b3ff85be00f48c33ad13b20caaad616b251d Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Wed, 29 Jun 2022 18:40:35 -1000 Subject: [PATCH] Bug 30430: (QA follow-up) Several fixes MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Several fixes : - Replace tab with spaces tag_210 : - Class 'value' and not 'valeur' - Loop on subfields must restrict to abcdg otherwise last() may not be correct (ie 214r and 214s) tag_214 : - Condition for coma after b should be same as after a : "position() != last()" tag_210 and tag_214 : - Space before ':' like in other fields - ':' before c or g does not exist in opac, removed from intranet file - Search links in intranet fixed (where composed with opac-search ^^) - Search links using 'str:encode-uri' like other places - Simplify title attribute with only 'Search for publisher' => Bad idea to use double quotes in a text tag_214_s and tag_214_r : - Loop on field+subfield otherwise last() may not be correct I've fixed intranet and copied to OPAC (only adapted search links) Signed-off-by: Fridolin Somers Signed-off-by: Tomás Cohen Arazi --- .../prog/en/xslt/UNIMARCslimUtils.xsl | 103 ++++++-------- .../bootstrap/en/xslt/UNIMARCslimUtils.xsl | 130 ++++++++---------- 2 files changed, 103 insertions(+), 130 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl index 408fceb70a..8860317cbf 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl +++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl @@ -31,13 +31,13 @@ - + - + - + @@ -46,17 +46,17 @@ Publication: - +
- + - + - : + : @@ -66,15 +66,9 @@
- - : - - /cgi-bin/koha/opac-search.pl?idx=pb&q= - - Search for publisher " - " - + /cgi-bin/koha/catalogue/search.pl?q=pb: + Search for publisher @@ -100,24 +94,17 @@ - Production: - - Distribution: - - Manufacture: - + Production: + Distribution: + Manufacture: - Copyright date: - - Protection date: - - Copyright date / protection date: - + Copyright date: + Protection date: + Copyright date / protection date: - Publication: - + Publication: @@ -127,22 +114,19 @@ - : + : - + , - /cgi-bin/koha/opac-search.pl?idx=pb&q= - - Search for publisher " - " - + /cgi-bin/koha/catalogue/search.pl?q=pb: + Search for publisher @@ -174,17 +158,18 @@ - Printing and/or Publishing Information Transcribed as Found in the Colophon: - - - - - . - - , - - - + Printing and/or Publishing Information Transcribed as Found in the Colophon: + + + + + . + + + , + + + @@ -192,18 +177,18 @@ - Printing and/or Publishing Information Transcribed as Found in the Main Source of - Information: - - - - - . - - , - - - + Printing and/or Publishing Information Transcribed as Found in the Main Source of Information: + + + + + . + + + , + + + diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl index b5a970a2c7..dc02e6fc8e 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl @@ -192,13 +192,13 @@ - + - + - + @@ -207,47 +207,44 @@ Publication: - +
-
- +
+ - + - - - : - + + + : + - - + + , - + - - /cgi-bin/koha/opac-search.pl?idx=pb&q= - - Search for publisher " - " - + + /cgi-bin/koha/opac-search.pl?q=pb: + Search for publisher - - + + , - + - - + + , - + - +
@@ -258,24 +255,17 @@ - Production: - - Distribution: - - Manufacture: - + Production: + Distribution: + Manufacture: - Copyright date: - - Protection date: - - Copyright date / protection date: - + Copyright date: + Protection date: + Copyright date / protection date: - Publication: - + Publication: @@ -285,22 +275,19 @@ - : + : - + , - /cgi-bin/koha/opac-search.pl?idx=pb&q= - - Search for publisher " - " - + /cgi-bin/koha/opac-search.pl?q=pb: + Search for publisher @@ -332,17 +319,18 @@ - Printing and/or Publishing Information Transcribed as Found in the Colophon: - - - - - . - - , - - - + Printing and/or Publishing Information Transcribed as Found in the Colophon: + + + + + . + + + , + + + @@ -350,18 +338,18 @@ - Printing and/or Publishing Information Transcribed as Found in the Main Source of - formation: - - - - - . - - , - - - + Printing and/or Publishing Information Transcribed as Found in the Main Source of Information: + + + + + . + + + , + + + -- 2.39.5