From d60439b96a708d28bd8612f99c279e69972811b5 Mon Sep 17 00:00:00 2001
From: Henry Bolshaw <bolshawh@parliament.uk>
Date: Tue, 13 Apr 2021 10:49:09 +0000
Subject: [PATCH] Bug 28140: Accessibility: OPAC - "sort_by" select isn't
 labelled on search results page

This patch adds a label to the sort function on the OPAC
results page to provide context to screen readers and improve
accessibility.

The label is visually hidden and does not change how the page
displays.

To test:
- Search for something on the OPAC
- Change how the results are sorted and confirm sort still works
- Confirm that there are no visual changes to the page
- Inspect the sort function to confirm it now has a label
- Ideally confirm the label works with a screenreader

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
index ad6c7eed7d..2fe0ecd021 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
@@ -180,6 +180,7 @@
                                         </div>
                                         [% UNLESS tag %]
                                             <div class="sort_by col-sm-auto">
+                                                <label for="sort_by" class="sr-only">Sort by:</label>
                                                 <select id="sort_by" class="resort form-control form-control-sm" name="sort_by">
                                                     [% INCLUDE 'resort_form.inc' %]
                                                 </select>
-- 
2.39.5