From d7fc581e6221f1423c56fdcc933eb2e4a8f6b3cd Mon Sep 17 00:00:00 2001 From: Shi Yao Wang Date: Wed, 18 May 2022 10:59:39 -0400 Subject: [PATCH] Bug 27519: Normalize Show/Don't show in system preferences Replace Display/Don't display (and some other pairs) by Show/Don't show in system preferences. Test plan: 1- Go to administration > system preferences 2- View any system preference with Display/Don't display pair of options (e.g. OPACAcquisitionDetails) 3- Apply the patch 4- Refresh the page and notice it is now a Show/Don't show pair instead 5- Loop the steps with other system preferences until satisfied Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit ed81d6bac6db499412a22f20ac45003da1aab0b1) Signed-off-by: Lucas Gass --- .../en/modules/admin/preferences/admin.pref | 6 ++--- .../admin/preferences/authorities.pref | 4 ++-- .../admin/preferences/cataloguing.pref | 20 ++++++++-------- .../admin/preferences/enhanced_content.pref | 16 ++++++------- .../en/modules/admin/preferences/opac.pref | 24 +++++++++---------- .../modules/admin/preferences/searching.pref | 4 ++-- 6 files changed, 37 insertions(+), 37 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref index 2eab55ae03..593c8c3417 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref @@ -35,12 +35,12 @@ Administration: 1: Some 2: All - - - "Show itemtype icons in the staff interface: " - pref: noItemTypeImages default: 0 choices: - 1: "No" - 0: "Yes" + 1: "Don't show" + 0: "Show" + - "itemtype icons in the staff interface." - - "Default separator for columns in an exported CSV file: " - pref: CSVDelimiter diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref index 5be3a583ae..73e7f172e2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/authorities.pref @@ -4,8 +4,8 @@ Authorities: - pref: AuthDisplayHierarchy default: no choices: - 1: Display - 0: "Don't display" + 1: Show + 0: "Don't show" - broader term/narrower term hierarchies when viewing authorities. - - Use the following text to edit how authority records control indicators of attached bibliographic fields (and possibly subfield $2).
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref index 86840eff5a..41399d7c97 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref @@ -9,14 +9,14 @@ Cataloging: - - pref: advancedMARCeditor choices: - 1: "Don't display" - 0: Display + 1: "Don't show" + 0: Show - descriptions of fields and subfields in the MARC editor. - - pref: EasyAnalyticalRecords choices: - 1: Display - 0: "Don't display" + 1: Show + 0: "Don't show" - "easy ways to create analytical record relationships." - - pref: EnableAdvancedCatalogingEditor @@ -59,8 +59,8 @@ Cataloging: - - pref: SpineLabelShowPrintOnBibDetails choices: - 1: Display - 0: "Don't display" + 1: Show + 0: "Don't show" - buttons on the bibliographic details page to print item spine labels. - Record structure: @@ -192,8 +192,8 @@ Cataloging: - - pref: hide_marc choices: - 1: "Don't display" - 0: Display + 1: "Don't show" + 0: Show - MARC tag numbers, subfield codes and indicators in MARC views. - - pref: LabelMARCView @@ -255,8 +255,8 @@ Cataloging: - - pref: AcquisitionDetails choices: - 1: Display - 0: "Don't display" + 1: Show + 0: "Don't show" - acquisition details on the bibliographic record detail page. - - "Show the following fields for deleted records after a merge:" diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref index b35984c1c1..c53b35677c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref @@ -286,14 +286,14 @@ Enhanced content: - - pref: LocalCoverImages choices: - 1: Display - 0: "Don't display" + 1: Show + 0: "Don't show" - local cover images on staff interface search and details pages. - - pref: OPACLocalCoverImages choices: - 1: Display - 0: "Don't display" + 1: Show + 0: "Don't show" - local cover images on OPAC search and details pages. - - pref: AllowMultipleCovers @@ -304,13 +304,13 @@ Enhanced content: - - pref: CustomCoverImages choices: - 1: Display - 0: "Don't display" + 1: Show + 0: "Don't show" - "custom remote URL images in the staff interface.
" - pref: OPACCustomCoverImages choices: - 1: Display - 0: "Don't display" + 1: Show + 0: "Don't show" - "custom remote URL images at the OPAC.
" - "Using the following URL:" - pref: CustomCoverImagesURL diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref index c582908e5a..ea9e864911 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ -102,12 +102,12 @@ OPAC: class: file - '
Options:
  • Enter "default" for the default stylesheet
  • Put a path to define an xslt file
  • Put a URL for an external specific stylesheet.
  • NOTE: The system preference PassItemMarcToXSLT must be enabled if your custom stylesheet utilizes data in the item fields
If you have multiple stylesheets for different languages the placeholder {langcode} will be replaced with current interface language.' - - - "Show itemtype icons in the OPAC: " - pref: OpacNoItemTypeImages default: 0 choices: - 1: "No" - 0: "Yes" + 1: "Don't show" + 0: "Show" + - "itemtype icons in the OPAC." - - pref: DisplayOPACiconsXSLT choices: @@ -449,7 +449,7 @@ OPAC: - pref: ShowReviewerPhoto choices: 1: Show - 0: Hide + 0: Don't show - reviewer's avatar beside comments in OPAC. The avatar will be searched on Libravatar using the patron's e-mail address. - - pref: OPACHoldRequests @@ -490,8 +490,8 @@ OPAC: - pref: OPACPopupAuthorsSearch default: 0 choices: - 1: Display - 0: Don't display + 1: Show + 0: Don't show - the list of authors/subjects in a popup for a combined search on OPAC detail pages. - - pref: OpacHoldNotes @@ -504,15 +504,15 @@ OPAC: - pref: OPACAcquisitionDetails default: 0 choices: - 1: Display - 0: Don't display + 1: Show + 0: Don't show - the acquisition details on OPAC detail pages. - - pref: OpacNewsLibrarySelect default: 0 choices: - 1: Display - 0: Don't display + 1: Show + 0: Don't show - a library selection list for news items in the OPAC. - - pref: OPACSuggestionAutoFill @@ -841,8 +841,8 @@ OPAC: - - pref: PatronSelfRegistrationPrefillForm choices: - 1: "Display and prefill" - 0: "Don't display and prefill" + 1: "Show and prefill" + 0: "Don't show and prefill" - "password and login form after a patron has self registered." - - pref: PatronSelfRegistrationConfirmEmail diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref index 5496b52636..69619fd6f8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref @@ -272,8 +272,8 @@ Searching: - - pref: BiblioItemtypeInfo choices: - 1: "Display" - 0: "Don't display" + 1: "Show" + 0: "Don't show" - ' Koha record level itemtype info on detail and result pages in the OPAC and staff interface. This info also displays if the item-level_itypes system preference is set to bibliographic record.' - - pref: PassItemMarcToXSLT -- 2.39.5