From f7893311481962c4ba7e51c26dce54466e21ccba Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 7 Jul 2011 10:01:34 -0400
Subject: [PATCH] Fix for Bug 6531 - clicking print button in opac causes 404
 error

opac-detail and opac-ISBDdetail both use window.print(), so I've
added that to opac-MARCdetail as well. I've also eliminated the
"javascript:" pseudo-protocol because it's pointless. I'd
prefer to have a real link for non-js users but that will have
to wait for another bug.

After applying this patch users with JS enabled should get a
print prompt after clicking the "Print" link on opac-MARCdetail.pl

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
---
 koha-tmpl/opac-tmpl/prog/en/modules/opac-ISBDdetail.tt | 2 +-
 koha-tmpl/opac-tmpl/prog/en/modules/opac-MARCdetail.tt | 2 +-
 koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-ISBDdetail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-ISBDdetail.tt
index 35fffc83f7..f9984a77b6 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-ISBDdetail.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-ISBDdetail.tt
@@ -62,7 +62,7 @@
         	[% END %]
 	[% END %]
 [% END %]
-        <li><a class="print" href="javascript:window.print();">Print</a></li>
+        <li><a class="print" href="#" onclick="window.print();">Print</a></li>
 [% IF ( virtualshelves ) %]
    [% IF ( opacuserlogin ) %] [% IF ( loggedinusername ) %]
         <li><a class="addtoshelf" href="/cgi-bin/koha/opac-addbybiblionumber.pl?biblionumber=[% biblionumber %]" onclick="Dopop('opac-addbybiblionumber.pl?biblionumber=[% biblionumber %]'); return false;">
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-MARCdetail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-MARCdetail.tt
index 68b0148678..284154ed13 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-MARCdetail.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-MARCdetail.tt
@@ -217,7 +217,7 @@ $(document).ready(function(){
             [% END %]
     [% END %]
 [% END %]
-        <li><a class="print" href="/cgi-bin/koha/opac-detailprint.pl?biblionumber=[% biblionumber %]" onclick="Dopop('opac-detailprint.pl?biblionumber=[% biblionumber %]'); return false;">
+        <li><a class="print" href="#" onclick="window.print();">
             Print
         </a></li>
 [% IF ( virtualshelves ) %]
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
index 60972cd927..3430cbbe1e 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
@@ -814,7 +814,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
         	[% END %]
 	[% END %]
 [% END %]
-        <li><a class="print" href="javascript:window.print();">Print</a></li>
+        <li><a class="print" href="#" onclick="window.print();">Print</a></li>
 [% IF ( virtualshelves ) %]
     [% IF ( opacuserlogin ) %][% IF ( loggedinusername ) %]
         <li><a class="addtoshelf" href="/cgi-bin/koha/opac-addbybiblionumber.pl?biblionumber=[% biblionumber %]" onclick="Dopop('opac-addbybiblionumber.pl?biblionumber=[% biblionumber %]'); return false;">
-- 
2.39.5