]> git.koha-community.org Git - koha.git/commit
Bug 27796: Centralise payment/transaction type handling
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 25 Feb 2021 17:28:33 +0000 (17:28 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 22 Apr 2021 13:51:19 +0000 (15:51 +0200)
commit297ef72a35640080435b508e4435263f2ed00c8a
treefb460425cda07d0304713552e7012e4403b75f88
parentdc7c62ec4d671ca35ce5d87131acb8dc48a0f5b5
Bug 27796: Centralise payment/transaction type handling

This patch centralises the payment/transaction type select options
handling so the SIP types are properly in all cases.

Test plan
1) Check that SIP payment types are properly hidden on the following
   modals.
1a) Refund modal on the borrower account page (The 'Account credit'
option should appear here)
1b) Payout modal on borrower account page
1c) Payment via paycollect
1d) Payment via point of sale
1e) Refund via point of sale, register details page (The 'Account
credit' option should only appear for debts associated to a patron and
not for payments accepted via point of sale)
2) Signoff

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 89cea3d7a791be8f160e492d664b0bfd2bd8d496)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/includes/payments.inc [deleted file]
koha-tmpl/intranet-tmpl/prog/en/includes/transaction_types.inc [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
koha-tmpl/intranet-tmpl/prog/en/modules/pos/pay.tt
koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
members/boraccount.pl
pos/register.pl