From 2e310fa7f38426b2a53bcca6e66d2ffae3688d17 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Mon, 4 Nov 2019 12:45:16 +0000 Subject: [PATCH] Bug 23184: Don't select branches for export by default This patch changes the include to require passing "selectall=1" to select all items This include is only used in this page, so changes should not have side effects git grep "branch-selector\.inc" This patch also corrects a mismatch in the class names To test: 1 - Browse to Tools->Export data 2 - Note all branches are selected 3 - Note this will exclude records wiuthout items if you click 'Export bibiographic records' 4 - Apply patch 5 - Visit page again 6 - Note no branches are selected by default 7 - Confirm 'Select all/Clear all' still work 8 - Note record with no items are exported by default now Signed-off-by: Myka Kennedy Stephens Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize --- .../intranet-tmpl/prog/en/includes/branch-selector.inc | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc index f05fa91f6a..35421e930e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/branch-selector.inc @@ -1,10 +1,4 @@ -[%# First check to see if we have anything selected, otherwise we select all %] -[% selectall = 1 %] -[% FOREACH branch IN branches %] - [% IF branch.selected %] - [% selectall = 0 %] - [% END %] -[% END %] +[%# To select all include with selectall = 1 %]

Select all | Clear all

@@ -13,7 +7,7 @@ [% IF branch.selected || (selectall == 1) %] [% ELSE %] - + [% END %] -- 2.39.5