From 6a7ef5c96550ac9eefa15ca841c4296e2fd24e8b Mon Sep 17 00:00:00 2001
From: David Bourgault <david.bourgault@inlibro.com>
Date: Wed, 4 Oct 2017 09:12:11 -0400
Subject: [PATCH] Bug 7468: Fix 'false' message on Firefox

It seems I was using an href to a javascript function in the 'Print Range' button, which Chrome didn't mind, but Firefox did understand.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 .../prog/en/modules/labels/label-edit-range.tt              | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-range.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-range.tt
index 79a21610f1..b3b7c7e8ab 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-range.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-range.tt
@@ -11,9 +11,9 @@
             str += "from=" + parseInt(document.getElementById("from-input").value) + "&";
             str += "to=" + parseInt(document.getElementById("to-input").value);
             return GB_showCenter('Export labels', "/cgi-bin/koha/labels/label-print.pl?" + str, 400, 800);
-            return;
         }
-        function print() {
+
+        function validate() {
             var error = false;
             if (parseInt(document.getElementById("from-input").value) == 0) {
                 document.getElementById("from-error").innerHTML = "  *Cannot be smaller than 1";
@@ -80,7 +80,7 @@
                             </div>
                         </form>
                         <div id="batch-manage" class="btn-toolbar">
-                            <a class="btn btn-default btn-sm" id="print" href="javascript:print()">
+                            <a class="btn btn-default btn-sm" id="print" onClick="validate()">
                                 <!-- This display a plus. Is there a more appropriate symbol to use?
                                 <i class="fa fa-plus"></i>
                                 -->
-- 
2.39.5